unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Kenichi Handa <handa@m17n.org>
Cc: emacs-devel@gnu.org, Miles Bader <miles@gnu.org>
Subject: Re: font-related hanging / general brokenness
Date: Thu, 19 Jun 2008 17:49:56 -0400	[thread overview]
Message-ID: <jwvskv9gkx0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <E1K9CEj-0003jO-Em@etlken.m17n.org> (Kenichi Handa's message of "Thu, 19 Jun 2008 13:59:05 +0900")

>> Updating to the newest CVS Emacs, Emacs goes into an infinite-loop upon
>> startup, with the following .emacs file (X resources are empty):

>> (custom-set-faces
>> ;; custom-set-faces was added by Custom.
>> ;; If you edit it by hand, you could mess it up, so be careful.
>> ;; Your init file should contain only one such instance.
>> ;; If there is more than one, they won't work right.
>> '(default ((t (:stipple nil :background "black" :foreground "white" :inverse-video nil :box nil :strike-through nil :overline nil :underline nil :slant normal :weight normal :height 90 :width normal :family "dejavu sans mono")))))

>> A backtrace shows that it seems to be infinitely recursing in the hairy
>> frame/face dance.

Yes, it turns out the problem is that the dance takes the above face
setting and (because it's applied to the `default' face), sets up the
frame's `font' parameter accordingly.  And that x_set_font then decides
to call Qface_set_after_frame_default which starts the whole process all
over again.

Now, I looked thorugh the history, and this call to
Qface_set_after_frame_default was introduced in 1997 by Richard, but
without any explanation of what it's there for.

I can easily fix the recursion problem (there's already some code for
that purpose in faces.el), but I'm strongly tempted to remove the call
altogether since it's very unclear what it's meant to do and it seems
clear to me that it does a lot more than what it might need to do (this
function will reset *every* face, not just `default').


        Stefan




  reply	other threads:[~2008-06-19 21:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <buobq1ycd5c.fsf@dhapc248.dev.necel.com>
2008-06-19  4:35 ` font-related hanging / general brokenness Miles Bader
2008-06-19  4:52   ` Miles Bader
2008-06-19  5:35   ` Kenichi Handa
2008-06-19  5:41     ` Miles Bader
2008-06-19  5:55       ` Miles Bader
2008-06-19  6:17         ` Kenichi Handa
2008-06-19  6:10       ` Kenichi Handa
2008-06-19  6:14         ` Miles Bader
2008-06-19  6:19           ` Kenichi Handa
2008-06-19  6:26             ` Miles Bader
2008-06-19  6:44               ` Kenichi Handa
2008-06-19  6:58                 ` Miles Bader
2008-06-19  7:44                   ` Kenichi Handa
2008-06-19  7:28                 ` Miles Bader
2008-06-19 14:23   ` Stefan Monnier
2008-06-19  4:59 ` Kenichi Handa
2008-06-19 21:49   ` Stefan Monnier [this message]
2008-06-20  5:05     ` Miles Bader
2008-06-20 14:00       ` Stefan Monnier
2008-06-22  7:48         ` Miles Bader
2008-06-23  3:05           ` Stefan Monnier
2008-06-23  4:35             ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvskv9gkx0.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=handa@m17n.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).