From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Ivan Kanis <expire-by-2009-09-16@kanis.fr>
Cc: Per Bothner <per@bothner.com>, Dan Nicolaescu <dann@ics.uci.edu>,
emacs-devel@gnu.org
Subject: Re: PATCH term optional bold
Date: Fri, 11 Sep 2009 13:48:31 -0400 [thread overview]
Message-ID: <jwvsketjrxm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87pr9x61tk.fsf@kanis.fr> (Ivan Kanis's message of "Fri, 11 Sep 2009 15:36:07 +0200")
> This small patch make optional the usage of bold attribute in term.
Could you give us some background explaining the motivation for this?
> +(defvar term-enable-bold t
> + "Set to nil to disable bold")
[...]
> - (when term-ansi-current-bold
> + (when (and term-ansi-current-bold
> + term-enable-bold)
> (setq term-current-face
> (append '(:weight bold) term-current-face)))
[...]
> - (when term-ansi-current-bold
> + (when (and term-ansi-current-bold
> + term-enable-bold)
> (setq term-current-face
> (append '(:weight bold) term-current-face)))
I think it'd be even better to do something like
> +(defvar term-bold-attribute '(:weight bold)
> + "Set to nil to disable bold")
[...]
> (when term-ansi-current-bold
> (setq term-current-face
> - (append '(:weight bold) term-current-face)))
> + (append term-bold-attribute term-current-face)))
[...]
> (when term-ansi-current-bold
> (setq term-current-face
> - (append '(:weight bold) term-current-face)))
> + (append term-bold-attribute term-current-face)))
WDYT?
Stefan
next prev parent reply other threads:[~2009-09-11 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 13:36 PATCH term optional bold Ivan Kanis
2009-09-11 17:48 ` Stefan Monnier [this message]
2009-09-12 7:32 ` Ivan Kanis
2009-09-12 13:56 ` Miles Bader
2009-09-12 16:35 ` Ivan Kanis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsketjrxm.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=expire-by-2009-09-16@kanis.fr \
--cc=per@bothner.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).