From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Deniz Dogan <deniz.a.m.dogan@gmail.com>
Cc: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] delete-trailing-whitespace on active region
Date: Thu, 10 Feb 2011 14:05:20 -0500 [thread overview]
Message-ID: <jwvsjvvu31v.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <AANLkTikN8NUJijN9rpUc-MsYEdO=XLXHfCYXnExtZm6Z@mail.gmail.com> (Deniz Dogan's message of "Thu, 10 Feb 2011 16:31:36 +0100")
> Attached is a reworked patch. Is it better now?
Yes, please install after fixing the details below.
> --
> Deniz Dogan
> === modified file 'lisp/simple.el'
> --- lisp/simple.el 2011-02-01 21:22:21 +0000
> +++ lisp/simple.el 2011-02-10 15:30:53 +0000
> @@ -614,22 +614,26 @@
> (if (looking-at "^[ \t]*\n\\'")
> (delete-region (point) (point-max)))))
> -(defun delete-trailing-whitespace ()
> +(defun delete-trailing-whitespace (&optional start end)
> "Delete all the trailing whitespace across the current buffer.
> All whitespace after the last non-whitespace character in a line is deleted.
> This respects narrowing, created by \\[narrow-to-region] and friends.
> -A formfeed is not considered whitespace by this function."
> - (interactive "*")
> +A formfeed is not considered whitespace by this function.
> +If the region is active, only delete whitespace within the region."
> + (interactive (if (use-region-p)
> + (list (region-beginning) (region-end))
> + (list (point-min) (point-max))))
> + (barf-if-buffer-read-only)
Nitpick: the barf-if-buffer-read-only should be in the interactive form.
You can keep passing nil rather than point-min/max when the region is
not used (see below).
> (save-match-data
> (save-excursion
> - (goto-char (point-min))
> - (while (re-search-forward "\\s-$" nil t)
> - (skip-syntax-backward "-" (save-excursion (forward-line 0) (point)))
> - ;; Don't delete formfeeds, even if they are considered whitespace.
> - (save-match-data
> - (if (looking-at ".*\f")
> - (goto-char (match-end 0))))
> - (delete-region (point) (match-end 0))))))
> + (goto-char start)
But here you shouldn't assume that start/end won't be nil, since the
function might be called without arguments from Elisp code.
Stefan
next prev parent reply other threads:[~2011-02-10 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 18:28 [PATCH] delete-trailing-whitespace on active region Deniz Dogan
2011-02-10 2:35 ` Stefan Monnier
2011-02-10 15:31 ` Deniz Dogan
2011-02-10 19:05 ` Stefan Monnier [this message]
2011-02-10 21:31 ` Johan Bockgård
2011-02-11 2:10 ` Stefan Monnier
2011-02-11 6:33 ` Deniz Dogan
2011-02-11 14:30 ` Stefan Monnier
2011-02-11 18:27 ` Deniz Dogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsjvvu31v.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=deniz.a.m.dogan@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).