unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: guile-devel <guile-devel@gnu.org>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] Support Guile backtraces in compilation mode.
Date: Fri, 08 Aug 2014 21:40:47 -0400	[thread overview]
Message-ID: <jwvsil64f4j.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <1407520265-23162-2-git-send-email-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Fri,  8 Aug 2014 19:51:05 +0200")

> +* Guile backtraces

Please add the Guile version here (ideally, the latest version known to
generate such backtraces).

> +    (guile-file "^In \\(.+\\):\n" 1)

AFAICT this will mark those lines as errors (aka red) whereas I think
these should be marked as supplemental info (aka green).

Other than that, it looks OK, so if someone wants to install it,
go ahead.


        Stefan



  reply	other threads:[~2014-08-09  1:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08 17:51 compilation-mode support for Guile backtrace; v2 much simplified Jan Nieuwenhuizen
2014-08-08 17:51 ` [PATCH] Support Guile backtraces in compilation mode Jan Nieuwenhuizen
2014-08-09  1:40   ` Stefan Monnier [this message]
2014-08-09  7:30     ` Jan Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsil64f4j.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=guile-devel@gnu.org \
    --cc=janneke@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).