From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Calling Lisp from undo.c's record_* functions Date: Thu, 19 Nov 2015 12:49:57 -0500 Message-ID: References: <83r3jpc2of.fsf@gnu.org> <87h9kkbz6k.fsf@russet.org.uk> <838u5wbmvu.fsf@gnu.org> <83ziyc9zs0.fsf@gnu.org> <83wptg9dcd.fsf@gnu.org> <87610zsd3u.fsf@russet.org.uk> <83io4z9ozx.fsf@gnu.org> <87wpte8fas.fsf@russet.org.uk> <83poz67zpd.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447955424 20835 80.91.229.3 (19 Nov 2015 17:50:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Nov 2015 17:50:24 +0000 (UTC) Cc: emacs-devel@gnu.org, Richard Stallman , Phillip Lord To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 19 18:50:15 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZzTLa-0005Kr-5r for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 18:50:14 +0100 Original-Received: from localhost ([::1]:43238 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzTLZ-0006sX-Nb for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 12:50:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzTLR-0006m2-E3 for emacs-devel@gnu.org; Thu, 19 Nov 2015 12:50:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzTLQ-00036E-MU for emacs-devel@gnu.org; Thu, 19 Nov 2015 12:50:05 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzTLM-00034q-UB; Thu, 19 Nov 2015 12:50:01 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id tAJHnvtu013913; Thu, 19 Nov 2015 12:49:58 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id D17BE602AE; Thu, 19 Nov 2015 12:49:57 -0500 (EST) In-Reply-To: <83poz67zpd.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Nov 2015 17:53:34 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5495=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5495> : inlines <4014> : streams <1540754> : uri <2085906> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194807 Archived-At: > prepare_to_modify_buffer. This seems to avoid calling Lisp while the > gap is being manipulated, but my question is: are there any pitfalls > to calling Lisp code on the level of insdel.c functions? I'd like to > hear your opinion before we decide whether to install the proposed > solution, or look for a safer one. As mentioned earlier, this function has been running Elisp code forever already via the before-change-functions hook. So we don't really have a choice here. Stefan