From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Generalizing make-composed-keymap (was: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695).) Date: Wed, 15 Jun 2016 11:23:33 -0400 Message-ID: References: <20160614214332.2901.16184@vcs.savannah.gnu.org> <20160614214332.C030F220116@vcs.savannah.gnu.org> <87h9cuyeip.fsf@gmx.net> <87d1nixzcu.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466004148 28803 80.91.229.3 (15 Jun 2016 15:22:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jun 2016 15:22:28 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 15 17:22:21 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bDCe5-00015C-EL for ged-emacs-devel@m.gmane.org; Wed, 15 Jun 2016 17:22:21 +0200 Original-Received: from localhost ([::1]:42895 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDCe4-0006Ex-R3 for ged-emacs-devel@m.gmane.org; Wed, 15 Jun 2016 11:22:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDCdw-0006E0-FV for emacs-devel@gnu.org; Wed, 15 Jun 2016 11:22:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDCdt-0004HK-6g for emacs-devel@gnu.org; Wed, 15 Jun 2016 11:22:12 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:46074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDCds-0004Gw-Vz for emacs-devel@gnu.org; Wed, 15 Jun 2016 11:22:09 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bDCdr-0000tL-39 for emacs-devel@gnu.org; Wed, 15 Jun 2016 17:22:07 +0200 Original-Received: from modemcable222.169-23-96.mc.videotron.ca ([96.23.169.222]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Jun 2016 17:22:07 +0200 Original-Received: from monnier by modemcable222.169-23-96.mc.videotron.ca with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Jun 2016 17:22:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 21 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: modemcable222.169-23-96.mc.videotron.ca User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:guSHluOKYtYFIHWJ+N0/QKFrUuY= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204395 Archived-At: BTW, currently make-composed-keymap takes a list of maps as argument, but I'm beginning to think it would make sense to also accept (KEY . CMD) elements in that list, so that we can just say (make-composed-keymap '((" " my-space-replacement) ("?" nil)) ; Just hide the old ? binding. my-parent-map) instead of (let ((map (make-sparse-keymap))) (set-keymap-parent map my-parent-map) (define-key map " " 'my-space-replacement) (define-key map "?" nil) map) WDYT? Stefan