unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Emacs 25.2, win64, env vars
Date: Thu, 27 Jul 2017 12:48:47 -0400	[thread overview]
Message-ID: <jwvshhhkev0.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: CAFgFV9MeOqmb72-o24MiTJoWkRUcbt82uxYpECxhW0TkqnCPtA@mail.gmail.com

> 1 - do nothing. Possibly find a place to document the fact that under
> Windows, emacs will inherit variables from the starting shell and that some
> shells
> may provide case sensitive environment variables.
> 2 - remove the case insensitive comparison for WINDOWSNT in
> getenv_internal_1 and replace it with a case sensitive one because some
> shells may
> provide case sensitive environment variables . This will result in handling
> case sensitive environment variables even under Windows. I guess it would
> need some testing to ensure
> everything works as expected, under MSYS2 or Cygwin.
> 3 - apply the fix I offered (or another equivalent one ?)  because it makes
> the handling of environment variables case symetrical for setenv and
> getenv, and both are case insensitive.

There's also

4 - first lookup case-sensitively, then if that fails, lookup with
    case-fold.

Whichever behavior is chosen, there's a somewhat orthogonal issue that
needs to be addressed: detect the ambiguity and warn the user when it occurs.


        Stefan




  reply	other threads:[~2017-07-27 16:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-11 20:33 Emacs 25.2, win64, env vars Fabrice Popineau
2017-06-11 21:33 ` Noam Postavsky
2017-06-12  4:40   ` Fabrice Popineau
2017-07-10 17:08     ` Eli Zaretskii
2017-07-11  9:17       ` Fabrice Popineau
2017-07-11 14:31         ` Noam Postavsky
2017-07-11 14:43         ` Eli Zaretskii
2017-07-11 16:24           ` Fabrice Popineau
2017-07-11 16:30             ` Eli Zaretskii
2017-07-11 18:48               ` Fabrice Popineau
2017-07-22  7:07             ` Eli Zaretskii
2017-07-22 20:02               ` Fabrice Popineau
2017-07-23 14:48                 ` Eli Zaretskii
2017-07-24 20:34                   ` Fabrice Popineau
2017-07-24 21:20                     ` Noam Postavsky
2017-07-25 14:16                     ` Eli Zaretskii
2017-07-27 16:35                       ` Fabrice Popineau
2017-07-27 16:48                         ` Stefan Monnier [this message]
2017-07-27 18:54                         ` Óscar Fuentes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvshhhkev0.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).