From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Completion functions in message-mode
Date: Fri, 13 Apr 2018 21:17:03 -0400 [thread overview]
Message-ID: <jwvsh7ysica.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 87h8oer459.fsf_-_@ericabrahamsen.net
> message-mode adds message-expand-group and message-tab-body-function to
> `completion-at-point-functions'. Both of these functions check if
> they're in an appropriate location, and bail if not, allowing other
> functions to do their thing.
I think it's OK for Gnus to keep using message-completion-alist, but
message-expand-name should use a completion table which can be extended,
so EUDC, BBDB, ecomplete, and YouNameIt can add themselves to it.
> Packages such as EUDC and BBDB put their own functions in
> `completion-at-point-functions' (in the message-mode hook).
That doesn't sound right: the code which decides if we're inside
a message header, and which header contains email addresses, and how
they're separated (i.e. the code which knows about the format of
messages) should squarely belong to message-mode and not to
BBDB/EUDC/...
Instead these backends should only provide completion tables that
provide user names, email addresses, or such data.
I.e. the completion-at-point-function should come from message.el and
the completion-tables it returns should come from BBDB/EUDC/...
Stefan
next prev parent reply other threads:[~2018-04-14 1:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180323044822.32467.63948@vcs0.savannah.gnu.org>
[not found] ` <20180323044823.1A70C20BDE@vcs0.savannah.gnu.org>
2018-03-23 5:18 ` [elpa] externals/ebdb 9e7a96f: Add experimental ebdb-completion-at-point-function Stefan Monnier
2018-03-23 5:50 ` Eric Abrahamsen
2018-03-23 10:54 ` Thomas Fitzsimmons
2018-03-23 12:10 ` Eric Abrahamsen
2018-03-23 12:11 ` Eric Abrahamsen
2018-03-23 12:23 ` Stefan Monnier
2018-04-14 1:02 ` Completion functions in message-mode (was: [elpa] externals/ebdb 9e7a96f: Add experimental ebdb-completion-at-point-function) Eric Abrahamsen
2018-04-14 1:17 ` Stefan Monnier [this message]
2018-04-14 2:33 ` Completion functions in message-mode Eric Abrahamsen
2018-04-14 17:37 ` Stefan Monnier
2018-04-25 19:24 ` Eric Abrahamsen
2018-06-06 21:09 ` Eric Abrahamsen
2018-04-14 12:59 ` Lars Ingebrigtsen
2018-04-14 16:17 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsh7ysica.fsf-monnier+gmane.emacs.devel@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).