From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: pcase: Semantics of atom QPATS Date: Sat, 16 Jun 2018 08:57:03 -0400 Message-ID: References: <87tvqbjwyf.fsf@web.de> <87k1r3qro3.fsf@web.de> <87vaaj9y4b.fsf@web.de> <83d0wr1ami.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529153752 13617 195.159.176.226 (16 Jun 2018 12:55:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Jun 2018 12:55:52 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 16 14:55:48 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fUAk6-0003Nr-W2 for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 14:55:47 +0200 Original-Received: from localhost ([::1]:51516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUAmE-0004tq-2l for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 08:57:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fUAla-0004tk-Sb for emacs-devel@gnu.org; Sat, 16 Jun 2018 08:57:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fUAlW-0002wW-20 for emacs-devel@gnu.org; Sat, 16 Jun 2018 08:57:18 -0400 Original-Received: from [195.159.176.226] (port=51317 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fUAlV-0002vU-Pi for emacs-devel@gnu.org; Sat, 16 Jun 2018 08:57:13 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fUAjK-0002B3-Jp for emacs-devel@gnu.org; Sat, 16 Jun 2018 14:54:58 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 13 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:mQhRuu+gGj4ntJDwHHIGm6aOJZM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226356 Archived-At: >> > Sure. Feel free to add support for floats while you're there. >> Ok. Is this patch ok for emacs-26? I don't see any reason to push it to emacs-26, it's not a bug-fix. >> - ((or (stringp qpat) (integerp qpat) (symbolp qpat)) `',qpat) >> + ((or (stringp qpat) (numberp qpat) (symbolp qpat)) `',qpat) > Any reasons to use numberp and not number-or-marker-p? Yes, we want to accept floats but not markers. Stefan