From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Help with adding an auxiliary bytecode table Date: Sun, 21 Apr 2019 00:11:25 -0400 Message-ID: References: <87pnpj9uod.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="63724"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 21 06:26:09 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hI43N-000GVp-6u for ged-emacs-devel@m.gmane.org; Sun, 21 Apr 2019 06:26:09 +0200 Original-Received: from localhost ([127.0.0.1]:48696 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hI43M-00081j-6G for ged-emacs-devel@m.gmane.org; Sun, 21 Apr 2019 00:26:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hI43G-0007oo-5k for emacs-devel@gnu.org; Sun, 21 Apr 2019 00:26:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hI3pG-0001zn-Di for emacs-devel@gnu.org; Sun, 21 Apr 2019 00:11:35 -0400 Original-Received: from [195.159.176.226] (port=42938 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hI3pF-0001zV-R6 for emacs-devel@gnu.org; Sun, 21 Apr 2019 00:11:34 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hI3pD-00012v-B7 for emacs-devel@gnu.org; Sun, 21 Apr 2019 06:11:31 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:yDQP+3raozlYad/R0Ks6XZAUHYk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235725 Archived-At: > I've attached a diff below that adds an auxiliary optable to bytecode.c > and attempts to integrate it into bytecode.el. I can run emacs -Q with > it, but when I run it with my configuration I get the following in > stderr: > > Invalid function: ((bytecomp "Wrong type argument: arrayp, nil" :error > "*Compile-Log*")) Use the debugger so you can get a more complete backtrace. > My initial reaction is that the stale bytecode is somehow incompatible, What/which stale bytecode? > The problem is that since memq is a bytecode operation, it turns out > to be faster than vector-memq for small input Why is that a problem? > unless I make sure that memq isn't turned into a bytecode op. > So since the current space in the lookup table is limited, I figured > that a prefix command that looks up in a secondary table would be > a good solution. We don't have too many bytecodes left, indeed, but there are still some, IIRC, so it's not indispensable to go a 2-byte bytecodes. Stefan