From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Adding olivetti to GNU ELPA Date: Thu, 09 May 2019 09:30:54 -0400 Message-ID: References: <83tvemzcn2.fsf@gnu.org> <9bb5fc63-61ae-44dc-a8d5-b67803eab1e5@www.fastmail.com> <83h8amz24g.fsf@gnu.org> <24cca761-36ea-4c16-bce1-e3651aad52c8@www.fastmail.com> <83ftq6yx5o.fsf@gnu.org> <83ftppii16.fsf@gnu.org> <875d1b0c-7f44-ba5d-4660-84637533b8f3@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="13106"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 09 15:31:55 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOj9P-0003DW-5d for ged-emacs-devel@m.gmane.org; Thu, 09 May 2019 15:31:55 +0200 Original-Received: from localhost ([127.0.0.1]:54636 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOj9O-0007Ym-4j for ged-emacs-devel@m.gmane.org; Thu, 09 May 2019 09:31:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOj8h-0007ER-HT for emacs-devel@gnu.org; Thu, 09 May 2019 09:31:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOj8f-00062N-Oo for emacs-devel@gnu.org; Thu, 09 May 2019 09:31:11 -0400 Original-Received: from [195.159.176.226] (port=35896 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hOj8f-000623-IT for emacs-devel@gnu.org; Thu, 09 May 2019 09:31:09 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hOj8Z-00023n-H6 for emacs-devel@gnu.org; Thu, 09 May 2019 15:31:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:KU30/qYS2L8RZlkcwOxKgunIqaQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236332 Archived-At: > 'set-window-margins' doesn't do much when margins don't change. So I > suppose that for some reason olivetti mode wants margins to change too > often. If so, could you try to find out why? I think the issue here is that even when margins "aren't modified", olivetti does change them, because it first sets them to 0 before setting them again to the previous value, as can be seen in olivetti--set-margins (which is function called for post-command-hook, window-size-change-functions, and friends): (defun olivetti--set-margins (&optional window-or-frame) [...] (olivetti-reset-window window-or-frame) [...] (set-window-margins window-or-frame left-margin right-margin)))) (defun olivetti-reset-window (window) [...] (set-window-margins window nil)) I don't know why it starts by calling olivetti-reset-window. But I think that for Emacs-27, it doesn't matter because it should only use window-size-change-functions so the extra (set-window-margins window nil) shouldn't be problematic. Stefan