From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add user option to disable location in bookmarks Date: Sat, 20 Jun 2020 18:50:54 -0400 Message-ID: References: <87sgep35cb.fsf@gmail.com> <87blld2x5h.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="22988"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Jamie Beardslee Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 21 00:51:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jmmKq-0005uf-43 for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Jun 2020 00:51:40 +0200 Original-Received: from localhost ([::1]:56042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmmKp-00069V-58 for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Jun 2020 18:51:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmmKL-0005N4-CI for emacs-devel@gnu.org; Sat, 20 Jun 2020 18:51:09 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmmKG-0008NY-4U for emacs-devel@gnu.org; Sat, 20 Jun 2020 18:51:08 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A735F44062D; Sat, 20 Jun 2020 18:51:02 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2EAEF440533; Sat, 20 Jun 2020 18:51:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1592693461; bh=iHXEBGedKQ+hzroH/Ax0682iRvZJsk+ENzSJjuesZ9o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=VHd58bFI2xHuhGykftLsOT4ui8v4TxvdZaxGLaG81q4mpw0pc9cgH7iwdQbjjGA+R GbZPRupkyTTdMq3XsFWz2WccmMVs/Uk4fwzmYy4fNwL63mjVGO3A0DtHOP06Lbcknt UYlJorxKI5eS7+0HHtpM9qWQvsxzcM+MrToUCk16Be3dzxfnSu3T63zAIUUu2/XZLl xtJwB4k+jZaXAo/ZtIgRQk1+suRvYnoSrfOH4zy+GTRWr9GNW2doXidADjmOJA9LhQ sFKl5WfbdLJ6C3Yb6mlusRr58v7O6bhrl7HQFvBENKiIMDz9uPGEPbrw2jQ5efcPj8 YxKaa1VVl554w== Original-Received: from alfajor (unknown [108.175.228.207]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 00B711201F1; Sat, 20 Jun 2020 18:51:00 -0400 (EDT) In-Reply-To: <87blld2x5h.fsf@gmail.com> (Jamie Beardslee's message of "Sun, 21 Jun 2020 10:24:42 +1200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/20 18:51:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252470 Archived-At: > =E2=80=98bookmark-set=E2=80=99 saves the position--by which I mean point = and context > strings--with no option (that I can find) of not saving it. > When using =E2=80=98bookmark-jump=E2=80=99, point will always be moved to= that > position, ignoring the position from save-place. Yes, that's on purpose. > My patch allows the user to choose whether or not the bookmark record > should be in control of the position. I think it makes sense, but I think it shouldn't be a global option. Maybe it should be a setting saved with the bookmark (i.e. when saving the bookmark you could specify not to save the location) or otherwise specified when jumping. Maybe a prefix command which causes the subsequent `bookmark-jump` to ignore the location info (and it could also cause a subsequent `bookmark-set` not to save the location)? Stefan