Re: master 1b0a922 1/2: Make M-x show obsolete commands (Bug#43300)

[Stefan Monnier <monnier@iro.umontreal.ca>]

>     Make M-x show obsolete commands (Bug#43300)
>     * lisp/simple.el (read-extended-command): Don't hide obsolete
>     commands.
>     (read-extended-command--annotation): Show an annotation for obsolete
>     commands that says what their new name is.

I think this doesn't push users away from obsolete commands
strongly enough.  If removing them from the list of completions is not
an option any more, then maybe we could/should force a kind of
"confirmation".  e.g. `M-x <obsolete-command> RET` would emit a short
"Really call obsolete `obsolete-command`?" and wait for an extra RET
before going ahead.


        Stefan


>  lisp/simple.el | 21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)
>
> diff --git a/lisp/simple.el b/lisp/simple.el
> index b5002dd..16ff863 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -1881,22 +1881,17 @@ to get different commands to edit and resubmit."
>  	   '(metadata
>  	     (annotation-function . read-extended-command--annotation)
>  	     (category . command))
> -         (let ((pred
> -                (if (memq action '(nil t))
> -                    ;; Exclude obsolete commands from completions.
> -                    (lambda (sym)
> -                      (and (funcall pred sym)
> -                           (or (equal string (symbol-name sym))
> -                               (not (get sym 'byte-obsolete-info)))))
> -                  pred)))
> -           (complete-with-action action obarray string pred))))
> +         (complete-with-action action obarray string pred)))
>       #'commandp t nil 'extended-command-history)))
>  
>  (defun read-extended-command--annotation (command-name)
> -  (let* ((function (and (stringp command-name) (intern-soft command-name)))
> -         (binding (where-is-internal function overriding-local-map t)))
> -    (when (and binding (not (stringp binding)))
> -      (format " (%s)" (key-description binding)))))
> +  (let* ((fun (and (stringp command-name) (intern-soft command-name)))
> +         (binding (where-is-internal fun overriding-local-map t))
> +         (obsolete (get fun 'byte-obsolete-info)))
> +    (cond (obsolete
> +           (format " (%s)" (car obsolete)))
> +          ((and binding (not (stringp binding)))
> +           (format " (%s)" (key-description binding))))))
>  
>  (defcustom suggest-key-bindings t
>    "Non-nil means show the equivalent key-binding when M-x command has one.