From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: cperl-mode: Eliminating references to obsolete packages Date: Wed, 23 Sep 2020 15:50:14 -0400 Message-ID: References: <63ad78b2-ec6b-8215-e775-db5889f4f94e@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25847"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Harald =?windows-1252?Q?J=F6rg?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 23 21:52:42 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLAoj-0006dX-6q for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Sep 2020 21:52:41 +0200 Original-Received: from localhost ([::1]:54096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLAoi-00085x-5d for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Sep 2020 15:52:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLAmZ-0007Pe-M0 for emacs-devel@gnu.org; Wed, 23 Sep 2020 15:50:27 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12120) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLAmX-0002AT-70 for emacs-devel@gnu.org; Wed, 23 Sep 2020 15:50:26 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 87E678117E; Wed, 23 Sep 2020 15:50:23 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 94D1280BAF; Wed, 23 Sep 2020 15:50:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600890621; bh=i4dq+P3RTa5Xyfz97lEAws72mnUr6fKcaQg7EokJHYU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KvGupE97GYZOYG/JRQMQr78s3D6l44YMoCNZUuZBEsmSV/lR90ycjEuPkAJohkyCA jphSoRPCSPiSF91UbNxm9tQ0dB/oTYCNz5nB1GLDrN7OzH8zBxCYG8w5J7IvIyL1HU thzZbGELADCWoGjYdQkInO2P7rgMbRd+UfJkxTcbQl4M0jsHOPSSDYwkWDmKRdWnv3 wMYxTUY/8qhyy6CK4N2uQRNxTcqcNGO5KiaS20qvjMslqhGEiam9yoaeRNCOwCo9pC 3dJJEhpLd8pXz0DwoUgsJrg1UPUcdDDSriOSi6hrB8e8Ww5UDXz0szLl3oqZiocnCm +NCF/p8V6einQ== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6DEED120186; Wed, 23 Sep 2020 15:50:21 -0400 (EDT) In-Reply-To: ("Harald =?windows-1252?Q?J=F6rg=22's?= message of "Wed, 23 Sep 2020 21:38:44 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/23 14:35:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256379 Archived-At: > I guess Ilya has retired? I assume he stopped using Emacs, but I have no idea, really. > Should I try to contact him? I don't see any need for it, but feel free to try. > I want to keep it compatible with at least Emacs 26, since this is the Sounds good. > feedback so far. As of now, I have found two commits which violate > that, one of which I consider fairly irrelevant (timing font-locking: > This was an issue 20 years ago, when computers where a bit slower). It's usually pretty easy to tweak changes so they don't break backward compatibility. > I am unsure about the procedure: Should the backwards-compatible > version live in a separate branch on Emacs? I think we don't need a separate branch. E.g. for format-prompt we can use a patch like the one below. If you can't think of a simple way to preserve backward compatibility in a specific situation, feel free to ask for help, Stefan diff --git a/lisp/progmodes/cperl-mode.el b/lisp/progmodes/cperl-mode.el index 468ffc949a..57bee5c4d7 100644 --- a/lisp/progmodes/cperl-mode.el +++ b/lisp/progmodes/cperl-mode.el @@ -6324,6 +6324,12 @@ cperl-word-at-point (get major-mode 'find-tag-default-function) 'find-tag-default)))))) =20 +(defalias 'cperl--format-prompt + (if (fboundp 'format-prompt) #'format-prompt ;New in Emacs=E2=89=A528 + (lambda (msg default) + (if default (format "%s (default %s): " msg default) + (concat msg ": "))))) + (defun cperl-info-on-command (command) "Show documentation for Perl command COMMAND in other window. If perl-info buffer is shown in some frame, uses this frame. @@ -6332,7 +6338,7 @@ cperl-info-on-command (interactive (let* ((default (cperl-word-at-point)) (read (read-string - (format-prompt "Find doc for Perl function" default)))) + (cperl--format-prompt "Find doc for Perl function" default)))) (list (if (equal read "") default read)))) @@ -8291,7 +8297,7 @@ cperl-perldoc (interactive (list (let* ((default-entry (cperl-word-at-point)) (input (read-string - (format-prompt "perldoc entry" default-entry)))) + (cperl--format-prompt "perldoc entry" default-entr= y)))) (if (string=3D input "") (if (string=3D default-entry "") (error "No perldoc args given")