From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/denote e24c9ddc12 2/2: Merge pull request #36 from jeanphilippegg/allow-no-keywords Date: Thu, 07 Jul 2022 11:37:30 -0400 Message-ID: References: <165707985011.9601.627786867785409616@vcs2.savannah.gnu.org> <20220706035731.254D5C01681@vcs2.savannah.gnu.org> <87fsjdkkcz.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25218"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Protesilaos Stavrou To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 07 17:39:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9Tb0-0006LM-Eb for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jul 2022 17:39:14 +0200 Original-Received: from localhost ([::1]:58342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9Taz-0006YG-Fc for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jul 2022 11:39:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9TZR-0004cb-Hx for emacs-devel@gnu.org; Thu, 07 Jul 2022 11:37:37 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9TZP-0001UV-7V for emacs-devel@gnu.org; Thu, 07 Jul 2022 11:37:36 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 44F23100163; Thu, 7 Jul 2022 11:37:33 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F3A22100130; Thu, 7 Jul 2022 11:37:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1657208252; bh=Wk8eGSJFbUxQynVN9yc4aCQm7q5pp6Qn7SsYsQn0/UI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SDpk01atoPa+a9QdAvWE6HEXz8weNkjLwrJFFd/VAnahNILStUumM+7++vC3ttdjV NX7q5Wm1A0AuLLnbwaceCy4PnWv1Il/BGKCUfcV9h6w+mLnLoRci1chB5MtmM9I3Qw 5590u+CCLJffU/46HbAdBBTeblLEBhV4heab9V3HmoC1l3iAkU5xWQ/Y7bAgAekXo7 C9zdg+UycLVlc4ZGSi1nfXFVxdciBMVQUzN11H/Fl/nri80GFf60HNYYHlKqeZmX23 Kl8kw14+7c3W9ePG3GNc3qlEZ8A+9AXDOyw8TSvDCP1bUNgML9KVUvKGUupu21iBeo AwmOmun0qhCLQ== Original-Received: from pastel (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CB85B120387; Thu, 7 Jul 2022 11:37:31 -0400 (EDT) In-Reply-To: <87fsjdkkcz.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 07 Jul 2022 15:34:04 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291930 Archived-At: >> (mapcar (if denote-allow-multi-word-keywords >> #'denote--sluggify >> #'denote--sluggify-and-join) >> keywords)) > > Is there any substantial advantage to pulling the if into the mapcar? It's good for karma because you get to reduce code duplication. Stefan