From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Stefan Monnier <monnier@iro.umontreal.ca>
Newsgroups: gmane.emacs.devel
Subject: Re: git tip: Error in winner-save-old-configurations
 (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]
Date: Thu, 08 Sep 2022 16:17:27 -0400
Message-ID: <jwvsfl17hd6.fsf-monnier+emacs@gnu.org>
References: <lzv8q0thdg.fsf@3c22fb11fdab.ant.amazon.com>
 <jwvmtbb9igq.fsf-monnier+emacs@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="7455"; mail-complaints-to="usenet@ciao.gmane.io"
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
To: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 08 22:18:33 2022
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1oWNyq-0001lj-Ut
	for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Sep 2022 22:18:33 +0200
Original-Received: from localhost ([::1]:42054 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1oWNyp-0002k6-H7
	for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Sep 2022 16:18:31 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54430)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <monnier@iro.umontreal.ca>)
 id 1oWNxt-0001J4-Sj
 for emacs-devel@gnu.org; Thu, 08 Sep 2022 16:17:34 -0400
Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25870)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <monnier@iro.umontreal.ca>)
 id 1oWNxs-0004Wn-1f
 for emacs-devel@gnu.org; Thu, 08 Sep 2022 16:17:33 -0400
Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 44F4780390;
 Thu,  8 Sep 2022 16:17:30 -0400 (EDT)
Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
 by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D29FB8024B;
 Thu,  8 Sep 2022 16:17:28 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
 s=mail; t=1662668248;
 bh=wKB6HGUKOvrouqTKwTbnsXc8ns3gfxJC5jL386ihMnY=;
 h=From:To:Subject:In-Reply-To:References:Date:From;
 b=Lwo0Ig7FjwxuoljT05FPnB5KofNWPX08XHMpCb8d1sU6dP0CH6XzjWUhaId5MuCNx
 G2K5X3PgOgupPEL2yuX86RolSuf65cU6KBdq4EmPFqD6Wxo4s/2jQOFlFP2WDx6Jt2
 f/gdPLY/iWOEh/DojILfTpOTBwM3bNc38+w5WL2ETGIj8ebZv4p/rhpP167Ys/G2ad
 pvLg2HdJS8Two5jX9R7hwHmxH+LmlKtSceW2VGI6FcGm6eWWS6GADu300es6LGRJYZ
 lLCNJX27uXR2JIJOc7/E8dr10P0UOc2OyynUX8AHTHWiXEt7criEgQjUOKLngohfQs
 cH3ubCv5AjMew==
Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242])
 by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C9D2412055D;
 Thu,  8 Sep 2022 16:17:28 -0400 (EDT)
In-Reply-To: <jwvmtbb9igq.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message
 of "Wed, 07 Sep 2022 14:00:04 -0400")
Received-SPF: pass client-ip=132.204.25.50;
 envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca
X-Spam_score_int: -42
X-Spam_score: -4.3
X-Spam_bar: ----
X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:295010
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/295010>

Stefan Monnier [2022-09-07 14:00:04] wrote:
> Sam Steingold [2022-09-06 15:47:23] wrote:
>> Error in winner-save-old-configurations (flyspell-post-command-hook):
>> (wrong-type-argument stringp nil)
>
> Hmm... actually, this is a good clue: in this error message the part
> after "in" should be the hook's name.
>
> So I suspect the problem comes from my
> commit 5cae71834bd55e0bf90689b12b801206ee8c9da9.
>
> More specifically, I suspect that the (hideous) patch below might fix
> your problem.  Could you confirm (so I can find a better fix)?

I pushed a fix to `main` which I hope is less brittle than my quick
hack, but somehow it seems that code is simply not run in the test suite
nor in my "simple interactive use test" (as evidenced by the fact that
it worked fine despite having swapped the args to `memcpy).

So if someone has a way to reproduce the problem it would be a great
addition to our test suite.


        Stefan