From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/opam-switch-mode 8b8670ca8b 1/3: feat(opam-switch-mode-lighter): Show the switch name in the mode-bar Date: Tue, 11 Jul 2023 18:09:12 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18035"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: "Erik Martin-Dorel" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 12 00:10:21 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJLYp-0004X1-JU for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Jul 2023 00:10:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJLXx-0005pi-Uk; Tue, 11 Jul 2023 18:09:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJLXt-0005pL-9D for emacs-devel@gnu.org; Tue, 11 Jul 2023 18:09:22 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJLXq-0007Gu-5F for emacs-devel@gnu.org; Tue, 11 Jul 2023 18:09:20 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 43B901000C3; Tue, 11 Jul 2023 18:09:14 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 30B4C100084; Tue, 11 Jul 2023 18:09:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1689113353; bh=I6t5MbmFvwICg6+TIBDB0kDcVU7lxHhB0+XLEXf9cbQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WYtToRKSYtoI4XugkazunQQXtviOsxz7TO8OziRRMC6zxlKAwfTB4GygiGT2jQIng MZGl1frv5hjucwT168/ZloYmeB9b9ZcytJC+3IHUdcvo/Lx9fwmTEz5IcjQIHFIsA2 wqAMGwVCdoAtCgHM/zr3vLOKYjvZwIVnMl53vFLf8grbIQPAjUWCp8FMU5+iwv/26j jx6DO2Mc+slNH2giGkec6HibDeT+SB8Pd4TbRFmCYwRuHAlYumJ6Hm9LoIF1L9OIPw /gMBH5mv29krdcFXZoMVHZjakVfMiKA/bQ8I+e5bhDnSJdh4x6+q6QydkLAtV6U0xc HB5uxOEDcQTmQ== Original-Received: from alfajor (69-165-150-192.dsl.teksavvy.com [69.165.150.192]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0C38F1202AD; Tue, 11 Jul 2023 18:09:13 -0400 (EDT) In-Reply-To: (Erik Martin-Dorel's message of "Tue, 11 Jul 2023 23:09:54 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307765 Archived-At: >> Instead of `redraw-display` you want `force-mode-line-update`. > OK thanks. But we specifically need to update the mode-line for *all* fra= mes. > While `force-mode-line-update` only deals with the current buffer, > and `(force-mode-line-update t)` just seems to deal with all buffers from= the current frame. > Do you confirm? No, `(force-mode-line-update t)` should apply to all frames. > Sure: I had done this slight duplication outside of `opam-switch-set-swit= ch` > because the need for `redraw-display` only showed up when using the menu > =E2=80=94 direct calls to `M-x opam-switch-set-switch =E2=80=A6` were fin= e. IIRC that's because the use of the minibuffer forces a more complete redisplay which happens to recompute those modelines, tho I'd be surprised if it recomputes the modelines of all frames. >> Also, in some circumstances the mode lines can be updated fairly often >> (e.g. after every key press, and/or every process output received by >> a filter), so it might be worthwhile to memoize/precompute the >> lighter rather than recompute it every time the modeline is updated. > > Thanks for the suggestion, but IINM your patch only precomputes the light= er once, > while it would need to be recomputed each time we change the opam switch, > otherwise the ligther becomes out-of-sync. No, I reset it to nil at the same time as I call `force-mode-line-update`, which should cause it to be recomputed at the next redisplay. > and given no subexpression of the current (opam-switch-mode-lighter) > involves any external system call, I'd say it is not that inefficient/cos= tly=E2=80=A6 It's not too bad, admittedly. > https://github.com/ocaml/merlin/blob/4f6c7cfee2344dd75e9568f25c0c1576521e= c049/emacs/merlin.el#L2046 > Are you OK with that point? It's up to you. Stefan