From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: jit-lock doesn't honor font-lock-lines-before Date: Thu, 01 Sep 2005 10:11:44 -0400 Message-ID: References: <4311B76B.1050406@gmx.at> <43140295.4000102@gmx.at> <43169E36.6090802@gmx.at> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1125584499 26384 80.91.229.2 (1 Sep 2005 14:21:39 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 1 Sep 2005 14:21:39 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 01 16:21:37 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EApuD-00078D-2G for ged-emacs-devel@m.gmane.org; Thu, 01 Sep 2005 16:19:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EApyR-0000ZH-PK for ged-emacs-devel@m.gmane.org; Thu, 01 Sep 2005 10:23:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EApwk-0008N9-RC for emacs-devel@gnu.org; Thu, 01 Sep 2005 10:21:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EApwf-0008Kp-JS for emacs-devel@gnu.org; Thu, 01 Sep 2005 10:21:40 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EApwe-0008FY-Hx for emacs-devel@gnu.org; Thu, 01 Sep 2005 10:21:36 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EApq2-0000cP-QQ; Thu, 01 Sep 2005 10:14:46 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 0D2392CF583; Thu, 1 Sep 2005 10:11:49 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 7812F4AC00A; Thu, 1 Sep 2005 10:11:44 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 61FB0504E; Thu, 1 Sep 2005 10:11:44 -0400 (EDT) Original-To: martin rudalics In-Reply-To: <43169E36.6090802@gmx.at> (martin rudalics's message of "Thu, 01 Sep 2005 08:22:46 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-4.844, requis 5, autolearn=not spam, AWL 0.06, BAYES_00 -4.90) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42549 Archived-At: > In `font-lock-default-fontify-region', immediately before the comment > ;; check to see if we should expand the beg/end area for > ;; proper multiline matches > insert either > (setq beg (line-beginning-position (1- font-lock-lines-before))) Oh, I see we violently agree. I've committed the change. > or - but this would have to be mentioned in the doc-string of > `font-lock-lines-before' - > (when font-lock-multiline > (setq beg (line-beginning-position (1- font-lock-lines-before)))) I'd rather not force people to use font-lock-multiline at the same time as font-lock-lines-before since they interact in non-trivial ways. I'd actually rather recommend to avoid using the two together. > remove the corresponding line from `font-lock-after-change-function' and > wait what happens? I'm still sceptical, though ... fontifications would > always overlap by `font-lock-lines-before' lines. The default setting of font-lock-lines-before makes it a nop (as it should). Major modes which rely on it should set it to the appropriate value. Stefan