unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: jit-lock doesn't honor font-lock-lines-before
Date: Thu, 01 Sep 2005 10:11:44 -0400	[thread overview]
Message-ID: <jwvr7c8zxu0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <43169E36.6090802@gmx.at> (martin rudalics's message of "Thu, 01 Sep 2005 08:22:46 +0200")

> In `font-lock-default-fontify-region', immediately before the comment

>            ;; check to see if we should expand the beg/end area for
>            ;; proper multiline matches

> insert either

>            (setq beg (line-beginning-position (1- font-lock-lines-before)))

Oh, I see we violently agree.  I've committed the change.

> or - but this would have to be mentioned in the doc-string of
> `font-lock-lines-before' -

>            (when font-lock-multiline
>              (setq beg (line-beginning-position (1- font-lock-lines-before))))

I'd rather not force people to use font-lock-multiline at the same time as
font-lock-lines-before since they interact in non-trivial ways.
I'd actually rather recommend to avoid using the two together.

> remove the corresponding line from `font-lock-after-change-function' and
> wait what happens?  I'm still sceptical, though ... fontifications would
> always overlap by `font-lock-lines-before' lines.

The default setting of font-lock-lines-before makes it a nop (as it
should).  Major modes which rely on it should set it to the
appropriate value.


        Stefan

  reply	other threads:[~2005-09-01 14:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-28 13:08 jit-lock doesn't honor font-lock-lines-before martin rudalics
2005-08-29  8:39 ` Richard M. Stallman
2005-08-30  6:54   ` martin rudalics
2005-08-31  0:23     ` Richard M. Stallman
2005-09-01  6:22       ` martin rudalics
2005-09-01 14:11         ` Stefan Monnier [this message]
2005-09-02  5:24           ` martin rudalics
2005-09-02  6:04         ` Richard M. Stallman
2005-09-02 14:30           ` Stefan Monnier
2005-08-31 14:36     ` Richard M. Stallman
2005-08-29 14:13 ` Stefan Monnier
2005-08-30 12:11   ` martin rudalics
2005-08-31  2:47     ` Stefan Monnier
2005-09-01  6:24       ` martin rudalics
2005-09-01 13:49         ` Stefan Monnier
2005-09-02  6:05           ` Richard M. Stallman
2005-09-02 18:45             ` Stefan Monnier
2005-09-03  9:07               ` Richard M. Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr7c8zxu0.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).