From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: Glenn Morris <rgm@gnu.org>, Miles Bader <miles@gnu.org>,
Bill Wohler <wohler@newt.com>,
emacs-devel@gnu.org
Subject: Re: undo weirdness with insert-file-contents
Date: Sun, 02 Mar 2008 00:02:10 -0500 [thread overview]
Message-ID: <jwvr6et20hr.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <47C88A51.7020205@gmx.at> (martin rudalics's message of "Fri, 29 Feb 2008 23:42:25 +0100")
> + if (inserted > 0
> + && CONSP (current_buffer->undo_list)
> + && (! NILP (XCAR (current_buffer->undo_list))))
> + /* Insert an undo boundary unless there's one here. */
> + current_buffer->undo_list =
> + Fcons (Qnil, current_buffer->undo_list);
We should use Fundo_boundary here.
> + else if (inserted > 0
> + && (! EQ (original_undo_list, Qt))
> + && (NILP (visit)) && (NILP (replace)))
> + /* Assure that the first insertion is counted as a change. */
> + {
> + current_buffer->undo_list = Qnil;
> + record_first_change ();
> + }
You use `else' between the two, but it's not clear why the two should be
mutually exclusive. And please mention `visit' in the comment.
Also if the file is empty, is this going to mark the buffer as modified
even though nothing was changed?
Stefan
next prev parent reply other threads:[~2008-03-02 5:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 7:46 undo weirdness with insert-file-contents Miles Bader
2008-02-28 9:56 ` martin rudalics
2008-02-28 11:01 ` Miles Bader
2008-02-28 13:12 ` martin rudalics
2008-02-28 16:52 ` Stefan Monnier
2008-02-28 19:31 ` martin rudalics
2008-02-28 20:01 ` Miles Bader
2008-02-28 22:19 ` martin rudalics
2008-02-28 21:35 ` Stefan Monnier
2008-02-28 22:21 ` martin rudalics
2008-02-28 17:45 ` Glenn Morris
2008-02-28 19:35 ` martin rudalics
2008-02-28 20:28 ` Glenn Morris
2008-02-28 22:20 ` martin rudalics
2008-02-29 22:42 ` martin rudalics
2008-03-02 5:02 ` Stefan Monnier [this message]
2008-03-02 12:44 ` martin rudalics
2008-03-02 19:07 ` Stefan Monnier
2008-03-02 22:05 ` martin rudalics
2008-03-03 2:15 ` Stefan Monnier
2008-03-03 9:09 ` martin rudalics
2008-03-03 21:03 ` Stefan Monnier
2008-03-07 9:33 ` martin rudalics
2008-03-07 22:04 ` Stefan Monnier
2008-03-08 9:55 ` martin rudalics
2008-03-02 22:18 ` Bill Wohler
2008-03-03 9:09 ` martin rudalics
2008-02-29 5:50 ` Bill Wohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr6et20hr.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=rgm@gnu.org \
--cc=rudalics@gmx.at \
--cc=wohler@newt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).