From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: tab widths with a remapped default face Date: Fri, 06 Jun 2008 01:53:59 -0400 Message-ID: References: <6163snp2bo.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1212731666 13492 80.91.229.12 (6 Jun 2008 05:54:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Jun 2008 05:54:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: Miles Bader Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 06 07:55:07 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K4Uuo-00057s-52 for ged-emacs-devel@m.gmane.org; Fri, 06 Jun 2008 07:55:06 +0200 Original-Received: from localhost ([127.0.0.1]:39064 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K4Uu1-0003jU-6g for ged-emacs-devel@m.gmane.org; Fri, 06 Jun 2008 01:54:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K4Utv-0003jL-DU for emacs-devel@gnu.org; Fri, 06 Jun 2008 01:54:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K4Utt-0003j0-PT for emacs-devel@gnu.org; Fri, 06 Jun 2008 01:54:10 -0400 Original-Received: from [199.232.76.173] (port=57841 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K4Utt-0003iv-HS for emacs-devel@gnu.org; Fri, 06 Jun 2008 01:54:09 -0400 Original-Received: from 206-248-132-168.dsl.teksavvy.com ([206.248.132.168]:53684 helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K4Utp-0001k3-Rh; Fri, 06 Jun 2008 01:54:06 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 53E2CB4248; Fri, 6 Jun 2008 01:53:59 -0400 (EDT) In-Reply-To: <6163snp2bo.fsf@fencepost.gnu.org> (Miles Bader's message of "Fri, 06 Jun 2008 01:19:55 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98492 Archived-At: > The following patch seems to fix the bad tab rendering when the default > face is altered using face remapping. Any objections? > It will also change the way tabs are computed for explicit faces (and > other implicit faces such as the region), but I think it's probably > usually the right thing to do for those cases too. IIUC your patch changes the TAB size to depend on the face applied to the TAB. The current code was consciously not doing that, IIRC, tho I can't quite remember the reason for it. Could we make it use the space_width of the font used for the default face? Stefan