unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Miles Bader <miles@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: tab widths with a remapped default face
Date: Fri, 06 Jun 2008 01:53:59 -0400	[thread overview]
Message-ID: <jwvr6bb6rgi.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <6163snp2bo.fsf@fencepost.gnu.org> (Miles Bader's message of "Fri, 06 Jun 2008 01:19:55 -0400")

> The following patch seems to fix the bad tab rendering when the default
> face is altered using face remapping.  Any objections?

> It will also change the way tabs are computed for explicit faces (and
> other implicit faces such as the region), but I think it's probably
> usually the right thing to do for those cases too.

IIUC your patch changes the TAB size to depend on the face applied to
the TAB.  The current code was consciously not doing that, IIRC, tho
I can't quite remember the reason for it.

Could we make it use the space_width of the font used for the
default face?


        Stefan




  reply	other threads:[~2008-06-06  5:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06  5:19 tab widths with a remapped default face Miles Bader
2008-06-06  5:53 ` Stefan Monnier [this message]
2008-06-06  7:26   ` Miles Bader
2008-06-06  7:53     ` Stefan Monnier
2008-06-06 19:34       ` Gerd Möllmann
2008-06-06  8:08     ` Miles Bader
2008-06-06 19:13       ` Stefan Monnier
2008-06-06 21:41         ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr6bb6rgi.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).