From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99829: * help.el Date: Mon, 05 Apr 2010 15:31:51 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1270495922 3054 80.91.229.12 (5 Apr 2010 19:32:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 5 Apr 2010 19:32:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 05 21:32:01 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nys1g-0006Th-Vg for ged-emacs-devel@m.gmane.org; Mon, 05 Apr 2010 21:32:01 +0200 Original-Received: from localhost ([127.0.0.1]:42361 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nys1g-000571-AI for ged-emacs-devel@m.gmane.org; Mon, 05 Apr 2010 15:32:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nys1b-00056i-NA for emacs-devel@gnu.org; Mon, 05 Apr 2010 15:31:55 -0400 Original-Received: from [140.186.70.92] (port=42603 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nys1a-00056a-CI for emacs-devel@gnu.org; Mon, 05 Apr 2010 15:31:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nys1Z-0000Kw-15 for emacs-devel@gnu.org; Mon, 05 Apr 2010 15:31:54 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:3637 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nys1Y-0000Ks-Mg for emacs-devel@gnu.org; Mon, 05 Apr 2010 15:31:53 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAFLXuUvO+K6K/2dsb2JhbACbS3K3EYUHBIsq X-IronPort-AV: E=Sophos;i="4.51,366,1267419600"; d="scan'208";a="60246444" Original-Received: from 206-248-174-138.dsl.teksavvy.com (HELO ceviche.home) ([206.248.174.138]) by ironport2-out.pppoe.ca with ESMTP; 05 Apr 2010 15:31:51 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 37A81660BF; Mon, 5 Apr 2010 15:31:51 -0400 (EDT) In-Reply-To: (Juanma Barranquero's message of "Mon, 5 Apr 2010 20:23:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123218 Archived-At: >> Here's a prime example of what I sent yesterday: if you think about it, >> the "for IELM's sake" part of the comment would be very welcome in the >> code, so that's where it should be instead of in the ChangeLog. > Hm, I'm not sure. I changed it for IELM's sake, but any code that > calls the function and returns its result is going to benefit from it. > There's nothing *specifically* IEMLy in returning nil. That's a problem of the comment itself, not of where it's placed. My argument is only that it should go in a comment rather than in the ChangeLog. Stefan PS: And even if it can be useful in other circumstances it's still useful to explain which circumstance prompted the reaction. So if you really insist you could say "for the sake of IELM and maybe others".