From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99829: * help.el
Date: Mon, 05 Apr 2010 15:31:51 -0400 [thread overview]
Message-ID: <jwvr5mt3diq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <u2vf7ccd24b1004051123h4cfe455az3d072e8d8602940d@mail.gmail.com> (Juanma Barranquero's message of "Mon, 5 Apr 2010 20:23:31 +0200")
>> Here's a prime example of what I sent yesterday: if you think about it,
>> the "for IELM's sake" part of the comment would be very welcome in the
>> code, so that's where it should be instead of in the ChangeLog.
> Hm, I'm not sure. I changed it for IELM's sake, but any code that
> calls the function and returns its result is going to benefit from it.
> There's nothing *specifically* IEMLy in returning nil.
That's a problem of the comment itself, not of where it's placed.
My argument is only that it should go in a comment rather than in
the ChangeLog.
Stefan
PS: And even if it can be useful in other circumstances it's still
useful to explain which circumstance prompted the reaction. So if you
really insist you could say "for the sake of IELM and maybe others".
next prev parent reply other threads:[~2010-04-05 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1NykJ3-0007V6-Of@internal.in.savannah.gnu.org>
2010-04-05 13:55 ` [Emacs-diffs] /srv/bzr/emacs/trunk r99829: * help.el (describe-mode): Return nil (for IELM's sake) Stefan Monnier
2010-04-05 18:23 ` Juanma Barranquero
2010-04-05 19:31 ` Stefan Monnier [this message]
2010-04-05 19:45 ` [Emacs-diffs] /srv/bzr/emacs/trunk r99829: * help.el Juanma Barranquero
2010-04-06 0:37 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr5mt3diq.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).