From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Updated proposal for DEL to delete active region Date: Sat, 22 May 2010 21:33:02 -0400 Message-ID: References: <87ljbbbzl1.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1274578397 2009 80.91.229.12 (23 May 2010 01:33:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 23 May 2010 01:33:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 23 03:33:16 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OG042-0007YM-Jd for ged-emacs-devel@m.gmane.org; Sun, 23 May 2010 03:33:14 +0200 Original-Received: from localhost ([127.0.0.1]:40224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OG041-0000rC-Mf for ged-emacs-devel@m.gmane.org; Sat, 22 May 2010 21:33:13 -0400 Original-Received: from [140.186.70.92] (port=44778 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OG03v-0000pm-Bx for emacs-devel@gnu.org; Sat, 22 May 2010 21:33:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OG03u-0001Oz-1Z for emacs-devel@gnu.org; Sat, 22 May 2010 21:33:07 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:13903 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OG03t-0001Ov-TZ for emacs-devel@gnu.org; Sat, 22 May 2010 21:33:06 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAOci+EtFpZMM/2dsb2JhbACeEHK8J4UTBIw/ X-IronPort-AV: E=Sophos;i="4.53,284,1272859200"; d="scan'208";a="64856247" Original-Received: from 69-165-147-12.dsl.teksavvy.com (HELO pastel.home) ([69.165.147.12]) by ironport2-out.pppoe.ca with ESMTP; 22 May 2010 21:33:02 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 721068175; Sat, 22 May 2010 21:33:02 -0400 (EDT) In-Reply-To: <87ljbbbzl1.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 22 May 2010 13:44:58 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125095 Archived-At: > Here is an updated proposal, which binds C-d and DEL to new Lisp > commands `delete-forward' and `delete-backward', which delete the active > region if `delete-deletes-active-region' is non-nil. > It removes the variable `mouse-region-delete-keys', removing the special > handling of mouse selections. It also simplifies delete-backward-char, > moving the special overwrite-mode untabification into delete-backward. Looks pretty good now. Comments: - I don't think we want to change delete-backward-char. Instead, we want it to be an alias for delete-backward (or the reverse, I don't have any strong opinion either way), and we want to add it to byte-compile-interactive-only-functions (it should have been there, and we should put it there on the emacs-23 branch already). But yes, we can move it to Elisp at the same occasion. - the code you sent uses delete-deletes-region instead of delete-deletes-active-region at some places. - removing mouse-region-delete-keys should allow the removal of a lot more code (the highlighting code can be removed because the temporary transient mark mode takes care of it nowadays). The important part of this removal is that it should remove all the code that calls read-event waiting for the next command. Stefan