unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: Updated proposal for DEL to delete active region
Date: Sat, 22 May 2010 21:33:02 -0400	[thread overview]
Message-ID: <jwvr5l3if89.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ljbbbzl1.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 22 May 2010 13:44:58 -0400")

> Here is an updated proposal, which binds C-d and DEL to new Lisp
> commands `delete-forward' and `delete-backward', which delete the active
> region if `delete-deletes-active-region' is non-nil.
> It removes the variable `mouse-region-delete-keys', removing the special
> handling of mouse selections.  It also simplifies delete-backward-char,
> moving the special overwrite-mode untabification into delete-backward.

Looks pretty good now.  Comments:
- I don't think we want to change delete-backward-char.  Instead, we
  want it to be an alias for delete-backward (or the reverse, I don't
  have any strong opinion either way), and we want to add it to
  byte-compile-interactive-only-functions (it should have been there,
  and we should put it there on the emacs-23 branch already).
  But yes, we can move it to Elisp at the same occasion.
- the code you sent uses delete-deletes-region instead of
  delete-deletes-active-region at some places.
- removing mouse-region-delete-keys should allow the removal of a lot
  more code (the highlighting code can be removed because the temporary
  transient mark mode takes care of it nowadays).  The important part of
  this removal is that it should remove all the code that calls
  read-event waiting for the next command.


        Stefan



      parent reply	other threads:[~2010-05-23  1:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-22 17:44 Updated proposal for DEL to delete active region Chong Yidong
2010-05-22 18:37 ` Drew Adams
2010-05-22 19:02   ` Eli Zaretskii
2010-05-22 20:43     ` Drew Adams
2010-05-22 21:39       ` David Kastrup
2010-05-22 22:14         ` Drew Adams
2010-05-22 21:37   ` David Kastrup
2010-05-22 23:40   ` Chong Yidong
2010-05-23  0:30     ` Drew Adams
2010-05-23 17:10     ` Andreas Schwab
2010-05-24 21:03       ` Stefan Monnier
2010-05-23  1:33 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr5l3if89.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).