Hash functions for custom-safe-themes

Hash functions for custom-safe-themes

[Chong Yidong]

When we added custom-safe-themes about a year ago, we used SHA1 for
hashing, just because that was conveniently implemented by `sha1.el'.
Several months later, we got built-in SHA256 hashing on all platforms
thanks to Gnulib and the secure-hash primitive.

For future proofing, maybe it would be wise to switch to SHA256 for
custom-safe-themes, before the release.  Any thoughts?

Re: Hash functions for custom-safe-themes

[Leo]

On 2012-01-05 19:00 +0800, Chong Yidong wrote:
> Several months later, we got built-in SHA256 hashing on all platforms
> thanks to Gnulib and the secure-hash primitive.

This is not related to your question. I have two suggestions:

1. A secure-hash-command that user can invoke to get the hash of a buffer
2. Bind `: h' to a new command dired-secure-hash, that user can invoke
   to get the hash of a file in dired

These new additions are small but quite handy. Do you think we can do it
for 24.1?

Thanks.
Leo

Re: Hash functions for custom-safe-themes

[Stefan Monnier]

> These new additions are small but quite handy. Do you think we can do it
> for 24.1?

No,


        Stefan

Re: Hash functions for custom-safe-themes

[Chong Yidong]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> These new additions are small but quite handy. Do you think we can do it
>> for 24.1?
>
> No,

Agreed---now is not the time to add new features.  Switching
custom-safe-themes to SHA-2, however, is now or never, so I'm going to
go ahead and flip that switch.