From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Why is Elisp's defvar weird? And is eval_sub broken? Date: Thu, 19 Feb 2015 21:02:24 -0500 Message-ID: References: <1qltCjSEEBoLuJohq3kE1ocYjLaBgBtwfZoywxpTbYB@local> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1424397782 26084 80.91.229.3 (20 Feb 2015 02:03:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Feb 2015 02:03:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kelly Dean Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 20 03:02:57 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YOcvh-0003Vp-FF for ged-emacs-devel@m.gmane.org; Fri, 20 Feb 2015 03:02:57 +0100 Original-Received: from localhost ([::1]:58818 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOcvg-0000CT-Iw for ged-emacs-devel@m.gmane.org; Thu, 19 Feb 2015 21:02:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOcvc-0000BH-ML for emacs-devel@gnu.org; Thu, 19 Feb 2015 21:02:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOcvZ-0005Ix-GB for emacs-devel@gnu.org; Thu, 19 Feb 2015 21:02:52 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:9725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOcvZ-0005It-CK for emacs-devel@gnu.org; Thu, 19 Feb 2015 21:02:49 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AroTAPOG1lTO+LI//2dsb2JhbABbgwaDX4VTwGUEAgKBDUQBAQEBAQF8hA0BBAFWIxALNBIUGA0kiDgIziMBAQEHAQEBAR6PeAeEKgWKJ484iSeEc4F5gUUihAwggnMBAQE X-IPAS-Result: AroTAPOG1lTO+LI//2dsb2JhbABbgwaDX4VTwGUEAgKBDUQBAQEBAQF8hA0BBAFWIxALNBIUGA0kiDgIziMBAQEHAQEBAR6PeAeEKgWKJ484iSeEc4F5gUUihAwggnMBAQE X-IronPort-AV: E=Sophos;i="5.09,536,1418101200"; d="scan'208";a="110965988" Original-Received: from 206-248-178-63.dsl.teksavvy.com (HELO pastel.home) ([206.248.178.63]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 Feb 2015 21:02:48 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id A78EC1309; Thu, 19 Feb 2015 21:02:24 -0500 (EST) In-Reply-To: <1qltCjSEEBoLuJohq3kE1ocYjLaBgBtwfZoywxpTbYB@local> (Kelly Dean's message of "Fri, 20 Feb 2015 00:11:01 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183313 Archived-At: >> Your code is clearly meant to be inside desktop.el, so it's perfectly >> normal to have to add various extra declarations to reproduce some >> context before calling internal functions. > Should I add the closed-buffer tracker to desktop.el? I haven't looked at it and I don't use desktop.el (nor do I hack on it very much), so I don't really know. But since you seem to think that it's a feature that should be there, I suggest you submit it for inclusion as a patch. My comment was just meaning that it's normal to have to add such declarations when you're meddling in the internals of a package. Even if this meddling is bound to stay "external" either by its nature (e.g. it's only useful to your very particular case) or for whichever other reason. Stefan