From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Magnar Sveen <magnars@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: save-excursion and the mark
Date: Tue, 14 Apr 2015 16:16:38 -0400 [thread overview]
Message-ID: <jwvr3rmjx0x.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CALVcYyAuAPyRgd7hpnLzA7ewGTajt1-vChBATq9kqLGWmTbT6A@mail.gmail.com> (Magnar Sveen's message of "Tue, 14 Apr 2015 16:08:10 +0000")
> If you are indeed going forward with this change (why is that?),
There are various problems with the previous save-excursion semantics,
all linked to the mark-saving part of it, and this part is useless in
98% of the cases, useful in 1%, and harmful in 1%, so it's better to get
rid of it in my view.
Among the various problems, I actually fixed some recently (before
throwing out the code), but the remaining ones are ugly:
saving/restoring the mark includes saving/restoring the mark-active
state as well, and in the general case you'd also want to run the
(de)activate-mark-hook, which could break even more uses of
save-excursion which never expected it to run such hook code.
> then maybe we could get a save-mark function?
Since you're the only user so far, better write explicitly the exact
saving/restoring you need (especially since it's not obvious to me what
it is you really need, I guess you could start with something along the
lines of (cl-letf (((mark)) (mark-active mark-active)) ...)).
Stefan
next prev parent reply other threads:[~2015-04-14 20:16 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 4:44 save-excursion and the mark Stefan Monnier
2015-02-23 11:34 ` Oleh Krehel
2015-02-23 22:33 ` Stefan Monnier
2015-02-23 23:14 ` Oleh Krehel
2015-02-24 0:12 ` Artur Malabarba
2015-02-24 8:47 ` Oleh Krehel
2015-02-24 2:31 ` Alexis
2015-02-24 3:52 ` Stefan Monnier
2015-02-25 1:58 ` Yuri Khan
2015-02-24 15:37 ` Barry Warsaw
2015-02-24 19:27 ` Stefan Monnier
2015-02-24 20:11 ` Barry Warsaw
2015-02-24 20:49 ` Artur Malabarba
2015-02-25 3:01 ` Stefan Monnier
2015-02-25 3:25 ` Artur Malabarba
2015-02-25 16:31 ` Barry Warsaw
2015-02-25 16:42 ` Stefan Monnier
2015-02-25 17:17 ` Drew Adams
2015-02-25 18:30 ` Richard Stallman
2015-02-26 13:50 ` Stefan Monnier
2015-02-27 0:13 ` Richard Stallman
2015-02-27 13:49 ` Stefan Monnier
2015-02-27 23:46 ` Richard Stallman
2015-02-28 18:50 ` martin rudalics
2015-03-02 5:36 ` Stefan Monnier
2015-03-02 5:35 ` Stefan Monnier
2015-03-02 21:05 ` Richard Stallman
2015-03-03 16:34 ` Stefan Monnier
2015-03-04 12:01 ` Richard Stallman
2015-02-24 16:05 ` Andreas Röhler
2015-02-25 2:59 ` Stefan Monnier
2015-02-25 11:49 ` Andreas Röhler
2015-02-25 12:35 ` Ivan Shmakov
2015-02-25 13:05 ` Andreas Röhler
2015-02-25 14:00 ` Stefan Monnier
2015-02-25 17:13 ` Andreas Röhler
2015-02-25 9:18 ` Ivan Shmakov
2015-02-25 15:56 ` Eli Zaretskii
2015-04-06 18:45 ` Magnar Sveen
2015-04-07 21:37 ` Stefan Monnier
2015-04-08 1:57 ` Stefan Monnier
2015-04-14 16:08 ` Magnar Sveen
2015-04-14 20:16 ` Stefan Monnier [this message]
2015-04-15 4:14 ` Magnar Sveen
2015-04-15 12:53 ` Stefan Monnier
2015-04-15 13:49 ` Magnar Sveen
2015-04-15 14:59 ` Stefan Monnier
2015-04-18 1:02 ` Daniel Colascione
2015-04-15 14:24 ` Richard Stallman
2015-04-15 15:16 ` Phillip Lord
2015-04-19 15:28 ` Oleh Krehel
2015-04-20 2:03 ` Stefan Monnier
2015-04-20 6:31 ` Andreas Röhler
2015-04-23 10:03 ` Frank Fischer
2015-05-28 17:42 ` Nicolas Richard
-- strict thread matches above, loose matches on Subject: below --
2015-04-17 18:53 Lars Magne Ingebrigtsen
2015-04-18 4:26 ` Stefan Monnier
2015-04-18 12:30 ` Wolfgang Jenkner
2015-04-25 12:45 ` Lars Magne Ingebrigtsen
2015-04-25 13:23 ` Lars Magne Ingebrigtsen
2015-04-25 14:19 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr3rmjx0x.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=magnars@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).