From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types. Date: Thu, 21 Dec 2017 13:43:28 -0500 Message-ID: References: <20171211213729.41411-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513881713 5999 195.159.176.226 (21 Dec 2017 18:41:53 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 21 Dec 2017 18:41:53 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Emacs developers , Richard Stallman , Noam Postavsky To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 21 19:41:49 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eS5mt-00013P-II for ged-emacs-devel@m.gmane.org; Thu, 21 Dec 2017 19:41:47 +0100 Original-Received: from localhost ([::1]:35537 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eS5oq-0007tR-FW for ged-emacs-devel@m.gmane.org; Thu, 21 Dec 2017 13:43:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eS5oe-0007sC-58 for emacs-devel@gnu.org; Thu, 21 Dec 2017 13:43:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eS5oa-000108-0V for emacs-devel@gnu.org; Thu, 21 Dec 2017 13:43:36 -0500 Original-Received: from pmta11.teksavvy.com ([76.10.157.34]:54801) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eS5oZ-0000sY-Qn; Thu, 21 Dec 2017 13:43:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2F5RADb/zta/9GnSC1bHAEBAQQBAQoBA?= =?us-ascii?q?YM+gVqOQo8pggGSMIcOhUUChEpEEwEBAQEBAQEBAQNoKIUlAQQBeQULCw0BJhI?= =?us-ascii?q?UGDEtigkIpnkhAopMAQEIAiaDf4ISgz+DLop6IAWTMZAXoTYoh0s3mAM3IoFPM?= =?us-ascii?q?hoIMIJmglIdggUjikYBAQE?= X-IPAS-Result: =?us-ascii?q?A2F5RADb/zta/9GnSC1bHAEBAQQBAQoBAYM+gVqOQo8pggG?= =?us-ascii?q?SMIcOhUUChEpEEwEBAQEBAQEBAQNoKIUlAQQBeQULCw0BJhIUGDEtigkIpnkhA?= =?us-ascii?q?opMAQEIAiaDf4ISgz+DLop6IAWTMZAXoTYoh0s3mAM3IoFPMhoIMIJmglIdggU?= =?us-ascii?q?jikYBAQE?= X-IronPort-AV: E=Sophos;i="5.45,437,1508817600"; d="scan'208";a="15289573" Original-Received: from unknown (HELO pastel.home) ([45.72.167.209]) by smtp.teksavvy.com with ESMTP; 21 Dec 2017 13:43:29 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id DF13C607D3; Thu, 21 Dec 2017 13:43:28 -0500 (EST) In-Reply-To: (Philipp Stephani's message of "Thu, 21 Dec 2017 17:34:47 +0000") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.10.157.34 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221315 Archived-At: > My suggestion would be to either at least document this breaking change > (this patch), or forbid such records, Hello? We've been through this discussion enough times, I believe. I'm absolutely firmly completely totally opposed to such a check in `make-record`. Yes, a record of type `integer` or `hash-table` is not allowed. No, we don't want to enforce this with a check in `make-record`. > or change the return value in a non-breaking way (such as using > '(record integer) and "#r(integer)"). Other parts of Emacs rely on the fact that (eq (type-of X) (type-of X)), so if you want to return cons cells, you'll need to hash-cons them or something. And the use of `integer` as record type is incorrect in any case, so it would add complexity only to handle a situation that's already incorrect. You're making a mountain of a mole-hill, really. Stefan