From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>,
Richard Stallman <rms@gnu.org>,
Noam Postavsky <npostavs@users.sourceforge.net>
Subject: Re: [PATCH] * etc/NEWS: Document incompatibilities introduced by record types.
Date: Thu, 21 Dec 2017 13:43:28 -0500 [thread overview]
Message-ID: <jwvr2rodj1z.fsf-monnier+Inbox@gnu.org> (raw)
In-Reply-To: <CAArVCkQOBik02nc4yMpVYAEF79JcC=T1fmh9RpvjhYrz=vi7zA@mail.gmail.com> (Philipp Stephani's message of "Thu, 21 Dec 2017 17:34:47 +0000")
> My suggestion would be to either at least document this breaking change
> (this patch), or forbid such records,
Hello? We've been through this discussion enough times, I believe.
I'm absolutely firmly completely totally opposed to such a check in
`make-record`.
Yes, a record of type `integer` or `hash-table` is not allowed.
No, we don't want to enforce this with a check in `make-record`.
> or change the return value in a non-breaking way (such as using
> '(record integer) and "#r(integer)").
Other parts of Emacs rely on the fact that (eq (type-of X) (type-of X)),
so if you want to return cons cells, you'll need to hash-cons them or
something. And the use of `integer` as record type is incorrect in any
case, so it would add complexity only to handle a situation that's
already incorrect.
You're making a mountain of a mole-hill, really.
Stefan
next prev parent reply other threads:[~2017-12-21 18:43 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 21:37 [PATCH] * etc/NEWS: Document incompatibilities introduced by record types Philipp Stephani
2017-12-11 22:25 ` Clément Pit-Claudel
2017-12-21 16:35 ` Philipp Stephani
2017-12-12 3:21 ` Stefan Monnier
2017-12-12 19:13 ` Clément Pit-Claudel
2017-12-12 20:45 ` Stefan Monnier
2017-12-13 23:00 ` Richard Stallman
2017-12-14 14:08 ` Stefan Monnier
2017-12-14 22:16 ` Richard Stallman
2017-12-14 23:41 ` Stefan Monnier
2017-12-15 21:25 ` Richard Stallman
2017-12-14 22:17 ` Richard Stallman
2017-12-22 10:06 ` Eli Zaretskii
2017-12-21 17:29 ` Philipp Stephani
2017-12-13 23:00 ` Richard Stallman
2017-12-14 14:07 ` Stefan Monnier
2017-12-12 22:06 ` Richard Stallman
2017-12-12 22:20 ` Stefan Monnier
2017-12-13 15:41 ` Sam Steingold
2017-12-13 16:30 ` Stefan Monnier
2017-12-13 23:03 ` Richard Stallman
2017-12-14 14:13 ` Stefan Monnier
2017-12-13 1:03 ` Stefan Monnier
2017-12-13 1:12 ` Noam Postavsky
2017-12-13 1:29 ` Stefan Monnier
2017-12-13 17:40 ` Stephen Leake
2017-12-13 23:02 ` Richard Stallman
2017-12-14 14:12 ` Stefan Monnier
2017-12-14 22:16 ` Richard Stallman
2017-12-14 22:16 ` Richard Stallman
2017-12-21 17:34 ` Philipp Stephani
2017-12-21 18:43 ` Stefan Monnier [this message]
2017-12-22 18:46 ` Richard Stallman
2017-12-22 19:39 ` [SUSPECTED SPAM] " Stefan Monnier
2017-12-23 14:56 ` Richard Stallman
2017-12-23 14:56 ` make-record Richard Stallman
2017-12-23 15:53 ` make-record Stefan Monnier
2017-12-24 20:35 ` make-record Richard Stallman
2017-12-26 2:43 ` make-record Stefan Monnier
2017-12-26 19:41 ` make-record Richard Stallman
2017-12-12 22:05 ` [PATCH] * etc/NEWS: Document incompatibilities introduced by record types Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr2rodj1z.fsf-monnier+Inbox@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=npostavs@users.sourceforge.net \
--cc=p.stephani2@gmail.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).