From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Byte-compilation of custom themes Date: Fri, 02 Feb 2018 09:25:04 -0500 Message-ID: References: <87efmk2qk0.fsf@tcd.ie> <87vafjhu04.fsf@tcd.ie> <87po5po7ul.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1517588863 7618 195.159.176.226 (2 Feb 2018 16:27:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Feb 2018 16:27:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 02 17:27:39 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eheBI-0000Sc-Rv for ged-emacs-devel@m.gmane.org; Fri, 02 Feb 2018 17:27:16 +0100 Original-Received: from localhost ([::1]:38931 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eheDJ-0000YQ-44 for ged-emacs-devel@m.gmane.org; Fri, 02 Feb 2018 11:29:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehdDf-0003Uq-P2 for emacs-devel@gnu.org; Fri, 02 Feb 2018 10:26:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehdCb-0002cf-Mg for emacs-devel@gnu.org; Fri, 02 Feb 2018 10:25:39 -0500 Original-Received: from chicot.dit.umontreal.ca ([132.204.13.19]:41278) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ehdCb-0002aN-6T for emacs-devel@gnu.org; Fri, 02 Feb 2018 10:24:33 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id w12EP4OQ010901; Fri, 2 Feb 2018 09:25:04 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 10C84604C6; Fri, 2 Feb 2018 09:25:04 -0500 (EST) In-Reply-To: <87po5po7ul.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 01 Feb 2018 00:45:54 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6214=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6214> : inlines <6358> : streams <1777818> : uri <2585098> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 132.204.13.19 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222408 Archived-At: > I attach a patch with this amendment. Installed in the emacs-26 branch, thank you. > What I meant to ask is why built-in themes are not byte-compiled in > addition to being considered safe. Are there any arguments against > doing this, other than any performance gain being negligible? I can't think of any technical reason, indeed (except that we'd then have to special case this in the code so as to load the .elc file instead of the .el file). Stefan