From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 1a6f595: * src/minibuf.c (read_minibuf): Add a FIXME comment. Date: Tue, 24 Apr 2018 21:39:14 -0400 Message-ID: References: <20180424225022.24335.78516@vcs0.savannah.gnu.org> <20180424225023.4A3C620836@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1524620241 1882 195.159.176.226 (25 Apr 2018 01:37:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 25 Apr 2018 01:37:21 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 25 03:37:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fB9Mx-0000P1-EZ for ged-emacs-devel@m.gmane.org; Wed, 25 Apr 2018 03:37:15 +0200 Original-Received: from localhost ([::1]:33384 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fB9P4-0005vj-9a for ged-emacs-devel@m.gmane.org; Tue, 24 Apr 2018 21:39:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59132) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fB9Ox-0005ve-JG for emacs-devel@gnu.org; Tue, 24 Apr 2018 21:39:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fB9Ou-0002y3-Gi for emacs-devel@gnu.org; Tue, 24 Apr 2018 21:39:19 -0400 Original-Received: from pmta31.teksavvy.com ([76.10.157.38]:21709) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1fB9Ou-0002wU-Ar for emacs-devel@gnu.org; Tue, 24 Apr 2018 21:39:16 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2GBGQBq299a/8KkCkxbDgwBAQEBAQIBA?= =?us-ascii?q?QEBCAEBAQGDQ4FbiDaEPIwfAYIGHgFdgk+SLAsTgTSDHwQCAoJ4IjcVAQIBAQE?= =?us-ascii?q?BAQECAgJoKIUlBlYjEAs0EhQYDSSFIqkKiEWCP4ofhBqKRwKXfQiPaIYXhRMrj?= =?us-ascii?q?3sMgSUyI4FSMxoIMIJ/gkeNTFYjkH8BAQ?= X-IPAS-Result: =?us-ascii?q?A2GBGQBq299a/8KkCkxbDgwBAQEBAQIBAQEBCAEBAQGDQ4F?= =?us-ascii?q?biDaEPIwfAYIGHgFdgk+SLAsTgTSDHwQCAoJ4IjcVAQIBAQEBAQECAgJoKIUlB?= =?us-ascii?q?lYjEAs0EhQYDSSFIqkKiEWCP4ofhBqKRwKXfQiPaIYXhRMrj3sMgSUyI4FSMxo?= =?us-ascii?q?IMIJ/gkeNTFYjkH8BAQ?= X-IronPort-AV: E=Sophos;i="5.49,325,1520913600"; d="scan'208";a="27535258" Original-Received: from 76-10-164-194.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([76.10.164.194]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 21:39:14 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 69557AE7E0; Tue, 24 Apr 2018 21:39:14 -0400 (EDT) In-Reply-To: <20180424225023.4A3C620836@vcs0.savannah.gnu.org> (Paul Eggert's message of "Tue, 24 Apr 2018 18:50:22 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.10.157.38 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224857 Archived-At: > + /* Why does this code set print-escape-newlines? No call to Fprin1 > + or to Fprint is anywhere in sight. FIXME: Either remove the next > + two lines of code along with this comment, or replace this > + comment with an explanation for why the two lines are needed. */ > Fmake_local_variable (Qprint_escape_newlines); > print_escape_newlines = 1; My guess is that it's because the miniwindow is mostly single-line, so "prints" usually work better with \n than with LF. I expect that while there might not be any prin1/print in sight nowadays that probably hasn't always been the case. Stefan