unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 1a6f595: * src/minibuf.c (read_minibuf): Add a FIXME comment.
Date: Tue, 24 Apr 2018 21:39:14 -0400	[thread overview]
Message-ID: <jwvr2n4xe29.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20180424225023.4A3C620836@vcs0.savannah.gnu.org> (Paul Eggert's message of "Tue, 24 Apr 2018 18:50:22 -0400 (EDT)")

> +  /* Why does this code set print-escape-newlines?  No call to Fprin1
> +     or to Fprint is anywhere in sight.  FIXME: Either remove the next
> +     two lines of code along with this comment, or replace this
> +     comment with an explanation for why the two lines are needed.  */
>    Fmake_local_variable (Qprint_escape_newlines);
>    print_escape_newlines = 1;

My guess is that it's because the miniwindow is mostly single-line, so
"prints" usually work better with \n than with LF.  I expect that while
there might not be any prin1/print in sight nowadays that probably
hasn't always been the case.


        Stefan



       reply	other threads:[~2018-04-25  1:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180424225022.24335.78516@vcs0.savannah.gnu.org>
     [not found] ` <20180424225023.4A3C620836@vcs0.savannah.gnu.org>
2018-04-25  1:39   ` Stefan Monnier [this message]
2018-04-25  4:09     ` [Emacs-diffs] master 1a6f595: * src/minibuf.c (read_minibuf): Add a FIXME comment Paul Eggert
2018-04-25 11:59       ` Stefan Monnier
2018-04-25 19:30         ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr2n4xe29.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).