Re: call-process and incremental display of output

Re: call-process and incremental display of output

[John Shahid]

[ -help-gnu-emacs and +emacs-devel ]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> Ping.  Not sure if my previous email was lost in the ether.  FWIW, I am
>> still using that patch and didn't run into any issues.  It works as I
>> expected, i.e. when point is at eob, new text is inserted before the
>> point.
>
> This should go to emacs-devel.

Good point.  I didn't realize this thread was CC'ing help-gnu-emacs.  I
think there is enough context below for those who haven't been following
the original thread.

> FWIW, I noticed at least the following incompatibility with this patch:
>
>     emacs -Q
>     M-x ielm
>     M-x electric-pair-mode
>     (
>
> This should leave you with "()" and point between the two parens, but
> instead point is left after the closing paren.
>
> This is because the behavior of the electric-pair thingy is equivalent to
>
>     (insert "(")
>     (save-excursion
>       (insert ")"))
>
> which is indeed affected by this patch.

This will affect all modes derived from comint modes and all the minor
modes that could be enabled in those buffers.  That isn't great.  Maybe
the type of marker used in `save-excursion' should be controlled by a
different and/or new variable, which isn't great either.  I don't like
the idea of introducing more variables/customizations.

Unfortunately I don't have anymore ideas to share ATM.

JS

>         Stefan
>
>
>> John Shahid <jvshahid@gmail.com> writes:
>>
>>> FYI, I have been using this patch without any noticeable issues.  Not
>>> sure if we should merge it.
>>>
>>> Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>>>
>>>>> Sounds good.  I'll make the change locally and test it for a month or
>>>>> two and report back.
>>>>
>>>> FWIW, I'm running with the following change now:
>>>>
>>>>     diff --git a/src/editfns.c b/src/editfns.c
>>>>     index e995b38a44..db95a8a20a 100644
>>>>     --- a/src/editfns.c
>>>>     +++ b/src/editfns.c
>>>>     @@ -782,6 +782,12 @@ save_excursion_save (union specbinding *pdl)
>>>>      {
>>>>        eassert (pdl->unwind_excursion.kind == SPECPDL_UNWIND_EXCURSION);
>>>>        pdl->unwind_excursion.marker = Fpoint_marker ();
>>>>     +  /* Suggested by John Shahid <jvshahid@gmail.com> in the "call-process and
>>>>     +   * incremental display of output" thread of help-gnu-emacs.
>>>>     +   * This matches the manually-created behavior of compile.el's process filter
>>>>     +   * and probably others like comint as well.  */
>>>>     +  XMARKER (pdl->unwind_excursion.marker)->insertion_type
>>>>     +    = !NILP (Vwindow_point_insertion_type);
>>>>        /* Selected window if current buffer is shown in it, nil otherwise.  */
>>>>        pdl->unwind_excursion.window
>>>>          = (EQ (XWINDOW (selected_window)->contents, Fcurrent_buffer ())
>>>>
>>>> I haven't double checked that it does what I think it does, to be
>>>> honest, but at least after a mere 48h of normal use I haven't noticed
>>>> anything weird yet.
>>>>
>>>>
>>>>         Stefan

Re: call-process and incremental display of output

[Stefan Monnier]

> This will affect all modes derived from comint modes and all the minor
> modes that could be enabled in those buffers.  That isn't great.  Maybe
> the type of marker used in `save-excursion' should be controlled by a
> different and/or new variable, which isn't great either.  I don't like
> the idea of introducing more variables/customizations.
> Unfortunately I don't have anymore ideas to share ATM.

Maybe we should just add a `save-excursion-with-insertion-type` macro.


        Stefan