From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/2] Add module functions to convert from and to big integers. Date: Wed, 24 Apr 2019 16:57:46 -0400 Message-ID: References: <329aec43-8272-f39a-e7ef-e77804103a50@cs.ucla.edu> <20190423213218.35618-1-phst@google.com> <20190423213218.35618-2-phst@google.com> <837ebj2xx0.fsf@gnu.org> <83zhof1g76.fsf@gnu.org> <83y33z1fnh.fsf@gnu.org> <474c5b14-4151-6a5d-a388-7f41351bc83c@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="26276"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 24 22:58:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJOyX-0006im-FQ for ged-emacs-devel@m.gmane.org; Wed, 24 Apr 2019 22:58:41 +0200 Original-Received: from localhost ([127.0.0.1]:47189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJOyW-00034v-DB for ged-emacs-devel@m.gmane.org; Wed, 24 Apr 2019 16:58:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJOxv-00034W-P7 for emacs-devel@gnu.org; Wed, 24 Apr 2019 16:58:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJOxt-0004zD-SP for emacs-devel@gnu.org; Wed, 24 Apr 2019 16:58:03 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:54020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJOxs-0004pS-4y for emacs-devel@gnu.org; Wed, 24 Apr 2019 16:58:01 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3OKvleT019282; Wed, 24 Apr 2019 16:57:47 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 03D396AE07; Wed, 24 Apr 2019 16:57:47 -0400 (EDT) In-Reply-To: <474c5b14-4151-6a5d-a388-7f41351bc83c@cs.ucla.edu> (Paul Eggert's message of "Wed, 24 Apr 2019 13:15:16 -0700") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6532=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6532> : inlines <7059> : streams <1819622> : uri <2836635> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235884 Archived-At: >> I'm not sure I understand the details of the discussion, but if we >> sometimes include mini-gmp.h (or copies of parts of it) and sometimes >> gmp.h, isn't there a risk that a module built for "Emacs on >> amd64" will not work on "all" versions of "Emacs on amd64" (depending >> on whether it was built with GMP or with mini-gmp)? > > Yes, although the module fingerprint is supposed to catch problems > like that. Such problems can also be caused by compiling with -O2 > vs -O3, say. Really? I thought our module system was designed so modules aren't so tightly coupled to Emacs's internals [ I remember discussions around exposing the size of Lisp_Object, for example. ] Stefan