From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer Date: Mon, 27 May 2019 08:24:46 -0400 Message-ID: References: <20190525191039.14136.23307@vcs0.savannah.gnu.org> <20190525191040.CCD6C207F5@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="1710"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 27 14:26:17 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hVEhl-0000G2-Pa for ged-emacs-devel@m.gmane.org; Mon, 27 May 2019 14:26:17 +0200 Original-Received: from localhost ([127.0.0.1]:45189 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVEhk-0004sr-QY for ged-emacs-devel@m.gmane.org; Mon, 27 May 2019 08:26:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVEgQ-0004RI-Qg for emacs-devel@gnu.org; Mon, 27 May 2019 08:24:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVEgP-00063w-W6 for emacs-devel@gnu.org; Mon, 27 May 2019 08:24:54 -0400 Original-Received: from [195.159.176.226] (port=36406 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVEgP-00062B-PC for emacs-devel@gnu.org; Mon, 27 May 2019 08:24:53 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hVEgN-0016d9-TS for emacs-devel@gnu.org; Mon, 27 May 2019 14:24:51 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:k7NeRbqkxO6A76VlnPzhL8GARwI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237039 Archived-At: > A related issue: C-h f string-as-unibyte > > string-as-unibyte is a built-in function in `src/fns.c'. > > (string-as-unibyte STRING) > > This function is obsolete since 26.1; > use `encode-coding-string'. > Probably introduced at or before Emacs version 20.3. > This function does not change global state, including the match data. > > Having trawled through the elisp manual, for the life of me itʼs not > clear which coding system I should use. 'raw-text'? 'us-ascii'? > Something Else? The coding that most closely corresponds to what string-as-unibyte does is `emacs-internal`. In 90% of the cases, it's not what you want, tho because the code shouldn't have used string-as-unibyte in the first place, so you'll need to find out what the code *really* needs. Stefan