* Re: master 4eb7db5: Mouse rectangular region selection (bug#38013)
[not found] ` <20191127135327.3359020A22@vcs0.savannah.gnu.org>
@ 2019-11-27 22:10 ` Stefan Monnier
2019-11-28 11:14 ` Mattias Engdegård
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2019-11-27 22:10 UTC (permalink / raw)
To: Mattias Engdegård; +Cc: emacs-devel
[ Please don't take the below personally. ]
> +(defun mouse-drag-region-rectangle (start-event)
> + "Set the region to the rectangle that the mouse is dragged over.
> +This must be bound to a button-down mouse event."
> + (interactive "e")
[...]
Yuck! We *really* need to abstract that gunk into its own function so
we don't keep copying it between the various `FOO-drag-region` functions.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master 4eb7db5: Mouse rectangular region selection (bug#38013)
2019-11-27 22:10 ` master 4eb7db5: Mouse rectangular region selection (bug#38013) Stefan Monnier
@ 2019-11-28 11:14 ` Mattias Engdegård
0 siblings, 0 replies; 2+ messages in thread
From: Mattias Engdegård @ 2019-11-28 11:14 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
27 nov. 2019 kl. 23.10 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
> Yuck! We *really* need to abstract that gunk into its own function so
> we don't keep copying it between the various `FOO-drag-region` functions.
No disagreement here! Refactoring should proceed with care, though, as there may be some subtle differences.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-28 11:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20191127135325.25969.88418@vcs0.savannah.gnu.org>
[not found] ` <20191127135327.3359020A22@vcs0.savannah.gnu.org>
2019-11-27 22:10 ` master 4eb7db5: Mouse rectangular region selection (bug#38013) Stefan Monnier
2019-11-28 11:14 ` Mattias Engdegård
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).