From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Allow inhibiting 'auto-save-visited-mode' on a per-buffer basis. Date: Wed, 08 Apr 2020 10:58:34 -0400 Message-ID: References: <20200401175736.203124-1-phst@google.com> <83wo6yxb0s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="45440"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Philipp Stephani , Eli Zaretskii , Emacs developers To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 08 16:59:20 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMCAg-000Bgo-OG for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Apr 2020 16:59:18 +0200 Original-Received: from localhost ([::1]:37098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMCAf-0004CW-QW for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Apr 2020 10:59:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55789) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMCAA-0003nR-Ez for emacs-devel@gnu.org; Wed, 08 Apr 2020 10:58:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMCA9-0006af-7l for emacs-devel@gnu.org; Wed, 08 Apr 2020 10:58:46 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46233) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jMCA7-0006a5-Cg; Wed, 08 Apr 2020 10:58:43 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7E943100B5C; Wed, 8 Apr 2020 10:58:42 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8C1191004AF; Wed, 8 Apr 2020 10:58:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1586357916; bh=Zimq0/3I+cNJqELDowIigTIGnIINMsZ42G32gJ33FS0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DlaVGCMevyPLvpkxYlwYaFaa6yvS6weWW8ZnU/DcFJ6usBuru7ji0kZnjNDebE6H5 hHggFcMq7C9Iu4pVJas7E8aZKc2LINTfAbW6MZzei3TPbu2S9Vn6jCBtbAIUHj7v45 w+QnZ1Cdlnl82QE5J/d7goBC+82TNtuANtw9boz9ljRE2xSNW+zcv43b+Iuw96GA0d cCk9M+RiS7aiZgbygZnH/wCo/tiSJ/0HTDSxAqPgC4U7WYQBrJXyWdrCnkl4SykX6Q Mw4ocQAVStjdol42bJHPHk4XL3TohNmsbbY2EgV8YAqsQz6Wiu9qZdL200RKTPWzuI arKXLVsGkwDBg== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 368B212076D; Wed, 8 Apr 2020 10:58:36 -0400 (EDT) In-Reply-To: (Philipp Stephani's message of "Wed, 8 Apr 2020 13:43:20 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246674 Archived-At: > How strongly do people feel about having a minor mode for this? If not > too strongly, I'd go ahead with my original proposal, which is simpler > implementation-wise. I don't think you can do much simpler than the patch I sent and it lets users inhibit the mode in those mode where they don't want it with: (add-hook 'foo-mode-hook (lambda () (setq-local auto-save-visited-mode nil))) and it's "compatible" with a future addition of an actual minor mode. As mentioned, having such "redundant checks" is common practice for minor modes. Stefan