From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Feature branches review please Date: Thu, 05 Nov 2020 16:44:15 -0500 Message-ID: References: <20201104161200.tyeo2r5jibdahukb.ref@Ergus> <20201104161200.tyeo2r5jibdahukb@Ergus> <234bba7f-fd5c-ed39-8a5e-8a6ce3125bf1@inventati.org> <20201105210915.3rl3z6jngsrzgbwv@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30521"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gregory Heytings , Ergus , Manuel Uberti , Jean Louis To: Gregory Heytings via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 05 22:44:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kan3w-0007pw-0Q for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 22:44:56 +0100 Original-Received: from localhost ([::1]:58296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kan3v-0005Zl-1d for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 16:44:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kan3O-00058f-EX for emacs-devel@gnu.org; Thu, 05 Nov 2020 16:44:22 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28762) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kan3L-0008A4-Qi for emacs-devel@gnu.org; Thu, 05 Nov 2020 16:44:21 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3182D809BF; Thu, 5 Nov 2020 16:44:18 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2F8C580B69; Thu, 5 Nov 2020 16:44:16 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1604612656; bh=/1qPSXJbZCBSwgAPv+/eCzzIfMt7ezH+ZdisGJ0iNJk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=BNWa+MnDLNEj2Za0bB2L5uWyct3wQG0ZO/oukKdc4HENE8W+gLbVlTB5XkHgI/lQ6 PcEj2HDOaEX4N6G+FLKSDZyHTbr25Jpvtk34btYE6TJ4NNhpOVzsVkwPiKBtjBY9AP LymvL8/nNXSGAOQVWVDQfCDZcwbl3FWw2Z4NdZAWQgOtlhEEZEIbV7Uw5DsAy4mjmj ZPTnmf+QciYnGOAHe7f/UIdph8Dq7bvcZA3ND1WqzpB77WFotb/v59S8rZAhnBuKYA mptxK5+QvlloI6SiPq4rGM69iL1Zp3P8onLSk+i9/YOKQeXsiTMqE1/+nC1f4NLfDZ 6qfA34XmP/pXw== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EF9C31202FF; Thu, 5 Nov 2020 16:44:15 -0500 (EST) In-Reply-To: (Gregory Heytings via's message of "Thu, 05 Nov 2020 21:19:27 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 09:21:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258763 Archived-At: > This has been discussed at length earlier: it is in practice impossible to > calculate the height of the minibuffer, and to calculate the size of the > completion candidates list to insert in the minibuffer. Yet you need to do > both to have a correct solution with the approach of the branch. With the current display code on `master`, I don't think the behaviors you refer to can qualify as incorrect. You can argue that they are less often preferable than some other choice, but that's a far cry from incorrect, IMO, and then should be fairly uncommon. So it's definitely not very high priority and shouldn't decide whether we install a particular version of the code right now. Stefan