From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Gregory Heytings via "Emacs development discussions."
<emacs-devel@gnu.org>
Cc: Gregory Heytings <ghe@sdf.org>, Ergus <spacibba@aol.com>,
Manuel Uberti <manuel.uberti@inventati.org>,
Jean Louis <bugs@gnu.support>
Subject: Re: Feature branches review please
Date: Thu, 05 Nov 2020 16:44:15 -0500 [thread overview]
Message-ID: <jwvr1p7h4il.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <alpine.NEB.2.22.394.2011052211320453.15773@sdf.lonestar.org> (Gregory Heytings via's message of "Thu, 05 Nov 2020 21:19:27 +0000")
> This has been discussed at length earlier: it is in practice impossible to
> calculate the height of the minibuffer, and to calculate the size of the
> completion candidates list to insert in the minibuffer. Yet you need to do
> both to have a correct solution with the approach of the branch.
With the current display code on `master`, I don't think the behaviors
you refer to can qualify as incorrect. You can argue that they are
less often preferable than some other choice, but that's a far cry from
incorrect, IMO, and then should be fairly uncommon. So it's definitely
not very high priority and shouldn't decide whether we install
a particular version of the code right now.
Stefan
next prev parent reply other threads:[~2020-11-05 21:44 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201104161200.tyeo2r5jibdahukb.ref@Ergus>
2020-11-04 16:12 ` Feature branches review please Ergus
2020-11-04 23:18 ` Basil L. Contovounesios
2020-11-05 8:30 ` Gregory Heytings via Emacs development discussions.
2020-11-05 10:05 ` Jean Louis
2020-11-05 16:10 ` Gregory Heytings via Emacs development discussions.
2020-11-05 16:27 ` Manuel Uberti
2020-11-05 17:00 ` Gregory Heytings via Emacs development discussions.
2020-11-05 17:32 ` Jean Louis
2020-11-05 18:50 ` Stefan Monnier
2020-11-05 19:30 ` Jean Louis
2020-11-05 19:52 ` Eli Zaretskii
2020-11-05 21:55 ` Adam Porter
2020-11-05 22:18 ` hyperscope Jean Louis
2020-11-06 18:18 ` hyperscope Eduardo Ochs
2020-11-06 19:18 ` hyperscope Jean Louis
2020-11-06 5:50 ` Feature branches review please Jean Louis
2020-11-05 20:39 ` Gregory Heytings via Emacs development discussions.
2020-11-05 21:09 ` Ergus
2020-11-05 21:19 ` Gregory Heytings via Emacs development discussions.
2020-11-05 21:36 ` Jean Louis
2020-11-05 21:44 ` Stefan Monnier [this message]
2020-11-05 22:00 ` Gregory Heytings via Emacs development discussions.
2020-11-05 22:36 ` Ergus
2020-11-06 8:42 ` Gregory Heytings via Emacs development discussions.
2020-11-05 21:33 ` Jean Louis
2020-11-05 21:46 ` Basil L. Contovounesios
2020-11-05 22:24 ` Gregory Heytings via Emacs development discussions.
2020-11-05 22:48 ` Jean Louis
2020-11-06 9:19 ` Gregory Heytings via Emacs development discussions.
2020-11-06 10:51 ` Feature branches review please (ivy hello) Jean Louis
2020-11-06 11:17 ` Oleh Krehel
2020-11-06 11:42 ` Jean Louis
2020-11-06 11:49 ` Basil L. Contovounesios
2020-11-06 12:01 ` Jean Louis
2020-11-06 21:12 ` Basil L. Contovounesios
2020-11-06 11:57 ` Could ivy minibuffer stay where it is? Jean Louis
2020-11-06 15:20 ` Basil L. Contovounesios
2020-11-06 15:36 ` Jean Louis
2020-11-06 21:17 ` Basil L. Contovounesios
2020-11-07 12:51 ` Oleh Krehel
2020-11-07 17:23 ` Jean Louis
2020-11-08 11:21 ` Oleh Krehel
2020-11-08 12:51 ` Jean Louis
2020-11-06 13:56 ` Feature branches review please (ivy hello) Stefan Monnier
2020-11-06 14:10 ` Eli Zaretskii
2020-11-06 14:55 ` Stefan Monnier
2020-11-06 15:24 ` Jean Louis
2020-11-06 12:07 ` Gregory Heytings via Emacs development discussions.
2020-11-06 14:02 ` Stefan Monnier
2020-11-06 14:41 ` Gregory Heytings via Emacs development discussions.
2020-11-06 19:23 ` Jean Louis
2020-11-06 21:09 ` Gregory Heytings via Emacs development discussions.
2020-11-15 20:12 ` Feature branches review please Juri Linkov
2020-11-15 22:32 ` Drew Adams
2020-11-06 10:31 ` Alan Mackenzie
2020-11-06 10:55 ` Jean Louis
2020-11-05 17:22 ` Jean Louis
2020-11-05 13:25 ` Andrii Kolomoiets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr1p7h4il.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bugs@gnu.support \
--cc=emacs-devel@gnu.org \
--cc=ghe@sdf.org \
--cc=manuel.uberti@inventati.org \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).