From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 5065698: Move the =?utf-8?B?4oCYZGVjbGFyZeKAmQ==?= form before the interactive spec in 10 functions. Date: Thu, 21 Jan 2021 19:22:05 -0500 Message-ID: References: <20210120191935.5488.54008@vcs0.savannah.gnu.org> <20210120191936.DCB55209AB@vcs0.savannah.gnu.org> <87r1mfl3r5.fsf@gnus.org> <87h7nbs34v.fsf@mail.linkov.net> <87eeifqnve.fsf@mail.linkov.net> <87im7ruu92.fsf@mail.linkov.net> <874kjazlda.fsf@mail.linkov.net> <87v9bp7wft.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6881"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 22 01:23:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2kEE-0001fu-AG for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Jan 2021 01:23:06 +0100 Original-Received: from localhost ([::1]:56694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2kED-0003zV-Cu for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Jan 2021 19:23:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2kDM-0003Xa-Nc for emacs-devel@gnu.org; Thu, 21 Jan 2021 19:22:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2kDJ-0003fj-HQ for emacs-devel@gnu.org; Thu, 21 Jan 2021 19:22:11 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1A1F4101AA5; Thu, 21 Jan 2021 19:22:08 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2627D10021B; Thu, 21 Jan 2021 19:22:06 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611274926; bh=voxmCgi9wZxy9yUUMexq6swYHdG8YBnM8USH7Dp6lRI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nK3jD5EoCKwpwW5KyIFpAXeCiinwvQ0XPtNnav3Tb1sj/KazaOUrCPmA6FkUSeYQS ZdiU3Eu1oSyofTj0N0pf3Npdt3foI0FVHNjmB0H294D0Cca9dQvQc8UdlFEtV8rOhN IK3MEH1DyrpVdDtOcI8/Z1gLc6EiKbenh9AHDBm5KCHJhUc8N+wciM5NkU+R/+J/nr JGoZYxYtyJFeIFIJYDH4cwMcJyJnBt/iC0DhptlFcF9zHta6ozFhXPw3syecXgcoG9 9vtf/WcoDppvM3Pe85/7251gpFXgAMp1XBnlVx7GWkTy5WmspIFzeP0SVbD92+XGAO gIf0CGXtQtLqQ== Original-Received: from alfajor (unknown [45.72.224.181]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E657A12031C; Thu, 21 Jan 2021 19:22:05 -0500 (EST) In-Reply-To: <87v9bp7wft.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 22 Jan 2021 00:32:38 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263263 Archived-At: > - (t (message "Warning: Unknown defun property `%S' in %S" > - (car x) name))))) > + (t (message "%S:%d:Warning: Unknown defun property `%S'" > + name (count-lines (point-min) (point)) > + (car x)))))) I think `count-lines` is a problem because we don't know in which buffer we are when this is executed. Another approach could be to use something like `macroexp--warn-and-return`. Stefan