unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Thierry Volpiatto <thievol@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: `selected-frame` behavior have changed in emacs-28
Date: Sun, 25 Apr 2021 11:54:03 -0400	[thread overview]
Message-ID: <jwvr1iyuzyy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87sg3eilen.fsf@posteo.net> (Thierry Volpiatto's message of "Sun,  25 Apr 2021 12:33:48 +0000")

Hi Thierry,

Thierry Volpiatto [2021-04-25 12:33:48] wrote:
> Up to emacs-27.2 I was using this code:
>
>     (with-current-buffer helm-buffer
>       (let ((frame (selected-frame)))
>         [...]))
>
> selected-frame was returning the frame where helm-buffer was displayed.

Note that `with-current-buffer` never affects the selected frame (nor
the selected window), so the fact that `selected-frame` returned the
one that displayed `helm-buffer` had nothing to do with your
"(with-current-buffer helm-buffer".

> In emacs-28, it have the same behavior when helm starts from a normal
> buffer, but if I call helm from a minibuffer e.g. from M-:
> selected-frame is returning the wrong frame whereas in emacs-27, the
> frame handling helm-buffer is returned.
> I expect here having the same behavior in emacs-27 and emacs-28.
> Does something have changed in selected-frame?

My crystal ball tells me this change is linked to Alan's changes to the
handling of minibuffers.  I suggest you `M-x report-emacs-bug` about it
(and skip the "(with-current-buffer helm-buffer" part which just muddies
the water).


        Stefan




  reply	other threads:[~2021-04-25 15:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-25 12:33 `selected-frame` behavior have changed in emacs-28 Thierry Volpiatto
2021-04-25 15:54 ` Stefan Monnier [this message]
2021-04-25 18:28   ` Thierry Volpiatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr1iyuzyy.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=thievol@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).