From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Sat, 29 Oct 2022 12:57:49 -0400 Message-ID: References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <87a65v2ytp.fsf@posteo.net> <834jw33rmx.fsf@gnu.org> <87pmer0xtz.fsf@posteo.net> <83wn8z2aze.fsf@gnu.org> <878rle1i0k.fsf@posteo.net> <87ilkelc10.fsf@posteo.net> <878rl6syg8.fsf@posteo.net> <87zgdjqcu0.fsf@posteo.net> <87zgdivc3f.fsf@posteo.net> <874jvqv2u3.fsf@posteo.net> <875yg6qtbl.fsf@posteo.net> <87ilk33lqk.fsf@posteo.net> <87mt9epqlk.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24139"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Richard Stallman , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 29 18:58:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oopAd-00064y-MT for ged-emacs-devel@m.gmane-mx.org; Sat, 29 Oct 2022 18:58:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oop9v-0008DY-IE; Sat, 29 Oct 2022 12:58:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oop9m-0008D9-Ho for emacs-devel@gnu.org; Sat, 29 Oct 2022 12:58:02 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oop9k-0007vl-LN; Sat, 29 Oct 2022 12:58:02 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C6436440F48; Sat, 29 Oct 2022 12:57:52 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 343CE440F5A; Sat, 29 Oct 2022 12:57:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1667062671; bh=q5Nx90+OqMyNLYJTaFmjILyK5aZE429Pn80M05PRVvo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gA+fc79ciYZVSRGMcWwl09CT7gs7eN/NXgo0rkpdZ3Z1VEOduY3A4QyvWIZXPcn9g cXJ7h1Vg8ejIBF2rvmGvfv6WXu0UeWcHks642gEzf2N2KsLYxKiNsBluPWC0vlvLWx TGC2bA+Eqrgks5oMorK5Ul8BteVkDTrWMBzqBptvuDe8LNQUw1IFqhqYETGcng2uv0 vYfBlmGxHEafHZ/Ya1znaqD7iOFk6h9LDquQ9YEm8hHfGdvcTtfcfqAPXLgK0Hkaa0 kGgd5/CL+gAsvn7HLJIqIoqlQUGClNUI9Ya0nhBWfflwJ9Hgpu1GMzbRP/G4ZMLbjW tYm98ElGzuSPQ== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0493C120E8B; Sat, 29 Oct 2022 12:57:50 -0400 (EDT) In-Reply-To: <87mt9epqlk.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 29 Oct 2022 16:00:23 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298771 Archived-At: >> We're not there yet, but the above adds info which we >> can (and do in `elpa-admin.el`) extract from the VCS, so it's going >> "backward". IOW, it's making things worse rather than better. > > You mean the addition of :release-rev, right? Yes. > Yes, it could be extracted from the VCS, but finding a generic system > is tricky as you have mentioned. How about a new VC method > `last-change' that takes a region and returns the last revision that > affected it. Any backend that supports `annotate' ought to be able to > determine it, right? Fine by me. As mentioned earlier, there's a good chance that if you use a different VCS than Git, this method will sometimes end up selecting a different commit than `elpa-admin.el`, but if we insist on supporting a local VCS different from the one used by `elpa-admin.el`, then we probably have to live with that. Stefan