unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Petteri Hintsanen <petterih@iki.fi>,  emacs-devel@gnu.org
Subject: Re: Bindat can exhaust memory when unpacking to vector
Date: Sat, 04 Nov 2023 04:21:25 -0400	[thread overview]
Message-ID: <jwvr0l67x40.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83pm0q557b.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 04 Nov 2023 09:48:56 +0200")

>> But, again, users of Bindat can be expected to know that tainted data
>> should be sanitized.  And what is described above is an implementation
>> detail.  So it does not make much sense to mention this in the manual.
>
> Stefan, any comments?

Hmm... I'm also tempted to say it's the programmer's fault, yet at the
same time, it's BinDat which does the parsing so the programmer doesn't
really have much opportunity to sanitize the data beforehand (short of
doing a manual pre-parse which kind of defeats the purpose).

With `bindat-type`, it's not too hard to insert ELisp code within the
BinDat parsing, so it *can* be solved from there, but it's indeed not
something that's been seriously considered so far.

Kind of an embarrassing blind spot.  BinDat should instead encourage the
addition of sanity checks within the parsing code (including maybe add
specific support for it).


        Stefan




  reply	other threads:[~2023-11-04  8:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-22 19:36 Bindat can exhaust memory when unpacking to vector Petteri Hintsanen
2023-10-23 11:25 ` Eli Zaretskii
2023-10-23 19:36   ` Petteri Hintsanen
2023-10-24  4:34     ` tomas
2023-11-12 19:11       ` Petteri Hintsanen
2023-11-04  7:48     ` Eli Zaretskii
2023-11-04  8:21       ` Stefan Monnier [this message]
2024-03-10 21:58         ` Stefan Monnier
2024-03-19 20:09           ` Petteri Hintsanen
2024-03-19 21:08             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr0l67x40.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=petterih@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).