From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: master b0049c942b8: bytecomp.el: Warn for `, ' not within backquote construct Date: Mon, 05 Feb 2024 08:35:02 -0500 Message-ID: References: <170700201601.3724.18410252880023545872@vcs2.savannah.gnu.org> <20240203231336.5A511C0EFF8@vcs2.savannah.gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29285"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:1lK0NeZAVdfl8bJoDgqfupHIZJg= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 05 14:36:06 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rWz8o-0007Mf-EW for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Feb 2024 14:36:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rWz81-0002W7-OG; Mon, 05 Feb 2024 08:35:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWz7w-0002Mh-OX for emacs-devel@gnu.org; Mon, 05 Feb 2024 08:35:12 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWz7v-0003se-4v for emacs-devel@gnu.org; Mon, 05 Feb 2024 08:35:12 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rWz7s-0005f3-Tr for emacs-devel@gnu.org; Mon, 05 Feb 2024 14:35:09 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315890 Archived-At: >> bytecomp.el: Warn for `,' not within backquote construct >> (bytecomp--report-comma): New function with `compiler-macro' property. BTW, the compiler already emitted a warning for it, but saying only that there was a call to an unknown function `,`, and without specifying where that call was found. So now we get a duplicate warning: In my-foo: foo.el:4:7: Warning: ‘,’ called -- perhaps used not within backquote In end of data: foo.el: Warning: the function ‘,’ is not known to be defined. Maybe the better fix is to improve the "function ‘,’ is not known to be defined" warning so it points to the right location? Stefan