unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Emacs development discussions." <emacs-devel@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: master b0049c942b8: bytecomp.el: Warn for `, ' not within backquote construct
Date: Mon, 05 Feb 2024 08:35:02 -0500	[thread overview]
Message-ID: <jwvr0hrxco3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: s0dv874oote.fsf@yahoo.com

>>     bytecomp.el: Warn for `,' not within backquote construct
>>     (bytecomp--report-comma): New function with `compiler-macro' property.

BTW, the compiler already emitted a warning for it, but saying only
that there was a call to an unknown function `,`, and without specifying
where that call was found.

So now we get a duplicate warning:

    In my-foo:
    foo.el:4:7: Warning: ‘,’ called -- perhaps used not within backquote
    
    In end of data:
    foo.el: Warning: the function ‘,’ is not known to be defined.

Maybe the better fix is to improve the "function ‘,’ is not known to
be defined" warning so it points to the right location?


        Stefan




  parent reply	other threads:[~2024-02-05 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170700201601.3724.18410252880023545872@vcs2.savannah.gnu.org>
     [not found] ` <20240203231336.5A511C0EFF8@vcs2.savannah.gnu.org>
2024-02-04  4:06   ` master b0049c942b8: bytecomp.el: Warn for `, ' not within backquote construct Po Lu
2024-02-05  3:36     ` Richard Stallman
2024-02-05 12:46       ` Eli Zaretskii
2024-02-05 13:35     ` Stefan Monnier via Emacs development discussions. [this message]
2024-03-16  1:45       ` Richard Stallman
2024-03-16 15:08         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr0hrxco3.fsf-monnier+emacs@gnu.org \
    --to=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).