From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: wdired.el cleanup Date: Mon, 11 Apr 2005 15:02:02 -0400 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1113246134 11189 80.91.229.2 (11 Apr 2005 19:02:14 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 11 Apr 2005 19:02:14 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 11 21:02:07 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DL49l-0005DJ-7U for ged-emacs-devel@m.gmane.org; Mon, 11 Apr 2005 21:01:09 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DL3jv-0001Wk-Gi for ged-emacs-devel@m.gmane.org; Mon, 11 Apr 2005 14:34:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DL3jm-0001VU-07 for emacs-devel@gnu.org; Mon, 11 Apr 2005 14:34:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DL3jh-0001Tv-MW for emacs-devel@gnu.org; Mon, 11 Apr 2005 14:34:15 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DL3jh-0001Ts-It for emacs-devel@gnu.org; Mon, 11 Apr 2005 14:34:13 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DL4CQ-00037O-AM for emacs-devel@gnu.org; Mon, 11 Apr 2005 15:03:54 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 98FF634000F; Mon, 11 Apr 2005 15:02:14 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 1CA3E2CC035; Mon, 11 Apr 2005 15:02:03 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 063AFE6C24; Mon, 11 Apr 2005 15:02:02 -0400 (EDT) Original-To: JUAN-LEON Lahoz Garcia In-Reply-To: (JUAN-LEON Lahoz Garcia's message of "Mon, 11 Apr 2005 10:49:30 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-4.832, requis 5, autolearn=not spam, AWL 0.07, BAYES_00 -4.90) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:35869 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35869 > [ PS. Is there any reason not to bind C-x C-q in dired-mode-map by > default to wdired-change-to-wdired-mode? IMHO this key combination > is not easy to accidentally hit for wdired unaware users, but easy > to remember for wdired aware users ]. IIRC using C-x C-q is indeed the intention. I can't remembr why I didn't do it at the time, maybe I just got side-tracked. I do remember there were questions about the wdired->dired direction where users might want to be able to just make the buffer read-only with C-x C-q without wanting to "commit" the changes. > [ PS2. wdired has a mixed style in tabs characters and spaces (my > fault, for sure). I do not know policies about tabs characters here, No policy, other than "avoid gratuitous changes since they tend to cause spurious conflicts". So just don't worry about TABs/spaces. Stefan PS: I installed your patch, except for the mistaken change from wdired-mode-hook to wdired-mode-hooks.