From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: allout patch - more safe-local-variables, plus autoloads Date: Fri, 21 Apr 2006 13:15:50 -0400 Message-ID: References: <2cd46e7f0604171211s5ef0e820gebc4e68b2ce2606d@mail.gmail.com> <8764l7m40w.fsf-monnier+emacs@gnu.org> <87r73uji3b.fsf-monnier+emacs@gnu.org> <87u08oqhq3.fsf-monnier+emacs@gnu.org> <2cd46e7f0604210802t28837d4r7aef3d3231a26ea3@mail.gmail.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1145639790 30534 80.91.229.2 (21 Apr 2006 17:16:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 21 Apr 2006 17:16:30 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 21 19:16:27 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FWzEu-0003H8-D1 for ged-emacs-devel@m.gmane.org; Fri, 21 Apr 2006 19:16:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FWzEt-0000WR-PM for ged-emacs-devel@m.gmane.org; Fri, 21 Apr 2006 13:16:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FWzEg-0000UF-GH for emacs-devel@gnu.org; Fri, 21 Apr 2006 13:16:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FWzEd-0000TQ-Je for emacs-devel@gnu.org; Fri, 21 Apr 2006 13:16:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FWzEd-0000TN-9h for emacs-devel@gnu.org; Fri, 21 Apr 2006 13:15:59 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FWzGE-0003Te-Fn for emacs-devel@gnu.org; Fri, 21 Apr 2006 13:17:38 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 96EAF2CE9BE; Fri, 21 Apr 2006 13:15:58 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 370D2452A; Fri, 21 Apr 2006 13:15:51 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id F30CA715AB; Fri, 21 Apr 2006 13:15:50 -0400 (EDT) Original-To: "Ken Manheimer" In-Reply-To: <2cd46e7f0604210802t28837d4r7aef3d3231a26ea3@mail.gmail.com> (Ken Manheimer's message of "Fri, 21 Apr 2006 11:02:51 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53200 Archived-At: > seems to me we're heading down the road of duplicating the mechanisms > of the custom type system, and that we should be using it. If you check this mailing-list, you'll see that it all started with Richard suggesting exactly that and we ended up with `safe-local-variable'. Now, this doesn't mean it was a bad idea. Just that you can't rely solely on the custom type mostly because it may include unsafe values. But, yes, maybe we could add a special predicate that basically says "consider as safe anything that the custom type accepts". The only problem I can see with it is that the custom-type is typically not preloaded (even if you place a ;;;###autoload in front of the defcustom), so we'd either arrange for it to be preloaded or to force the corresponding package to be autoloaded whenever the variable appears in a "Local Variables" section. Stefan