unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Lennart Borgman <lennart.borgman.073@student.lu.se>,
	Eli Zaretskii <eliz@gnu.org>,
	emacs-devel@gnu.org
Subject: Re: Quote file name args to start-process-shell-command?
Date: Thu, 12 Oct 2006 10:47:45 -0400	[thread overview]
Message-ID: <jwvpscxbnpt.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <85y7rmou5t.fsf@lola.goethe.zz> (David Kastrup's message of "Thu\, 12 Oct 2006 09\:44\:14 +0200")

I think the current situation is misleading: the "&rest ARGS" gives the
impression that these are separate args to the command, whereas they're just
arbitrary strings concatenated to COMMAND (which really can itself be
anything rather than a file name).

Just as obviously, this can't be fixed by quoting the arguments, because it
would defeat the purpose: you may as well use `start-process' and avoid the
whole shell problem.

I suggest the patch below to fix this problem: let the caller do the
concatenation/quoting, so she gets what she expects.  It's really not that
big a deal.


        Stefan


* auto-adding monnier@iro.umontreal.ca--first/emacs--monnier--0--patch-405 to greedy revision library /home/monnier/tmp/arch-lib
* found immediate ancestor revision in library (monnier@iro.umontreal.ca--first/emacs--monnier--0--patch-404)
* patching for this revision (monnier@iro.umontreal.ca--first/emacs--monnier--0--patch-405)
--- orig/lisp/subr.el
+++ mod/lisp/subr.el
@@ -2304,11 +2304,9 @@
  an output stream or filter function to handle the output.
  BUFFER may be also nil, meaning that this process is not associated
  with any buffer
-COMMAND is the name of a shell command.
-Remaining arguments are the arguments for the command.
-Wildcards and redirection are handled as usual in the shell.
+COMMAND is the shell command to run.
 
-\(fn NAME BUFFER COMMAND &rest COMMAND-ARGS)"
+\(fn NAME BUFFER COMMAND)"
   (cond
    ((eq system-type 'vax-vms)
     (apply 'start-process name buffer args))

  parent reply	other threads:[~2006-10-12 14:47 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-11 20:32 Quote file name args to start-process-shell-command? Lennart Borgman
2006-10-12  4:27 ` Eli Zaretskii
2006-10-12  6:08   ` Lennart Borgman
2006-10-12  7:03     ` Eli Zaretskii
2006-10-12  7:44       ` David Kastrup
2006-10-12  8:15         ` Kim F. Storm
2006-10-12  8:24           ` David Kastrup
2006-10-12  9:08             ` Andreas Schwab
2006-10-12  8:49         ` Andreas Schwab
2006-10-12  9:27           ` David Kastrup
2006-10-12  9:41             ` Andreas Schwab
2006-10-12  9:49               ` David Kastrup
2006-10-12  9:53                 ` Andreas Schwab
2006-10-12 10:02                   ` David Kastrup
2006-10-12 11:23                     ` Andreas Schwab
2006-10-12 11:30                       ` David Kastrup
2006-10-12 18:50                 ` Stephen Leake
2006-10-12 19:47                   ` Stefan Monnier
2006-10-13 15:25                     ` Eli Zaretskii
2006-10-13 18:16                       ` Stefan Monnier
2006-10-13 19:03                         ` Eli Zaretskii
2006-10-13 20:18                           ` Stefan Monnier
2006-10-14 13:10                             ` Eli Zaretskii
2006-10-14 16:57                               ` Stefan Monnier
2006-10-14 18:26                                 ` Eli Zaretskii
2006-10-16  0:14                                   ` Stefan Monnier
2006-10-16  4:21                                     ` Eli Zaretskii
2006-10-16  6:44                                       ` Stefan Monnier
2006-10-16  9:22                                         ` Andreas Schwab
2006-10-16 18:46                                       ` Richard Stallman
2006-10-15 17:12                                 ` Richard Stallman
2006-10-12 10:54             ` Eli Zaretskii
2006-10-12 11:01               ` David Kastrup
2006-10-12 11:08                 ` Eli Zaretskii
2006-10-12 22:38                 ` Richard Stallman
2006-10-13  0:44                   ` Stefan Monnier
2006-10-13  6:02                     ` Lennart Borgman
2006-10-13  8:31                       ` Kim F. Storm
2006-10-13 19:24                   ` Eli Zaretskii
2006-10-12 10:35         ` Eli Zaretskii
2006-10-12 10:45           ` David Kastrup
2006-10-12 11:02             ` Eli Zaretskii
2006-10-12 11:25               ` David Kastrup
2006-10-12 11:41                 ` Eli Zaretskii
2006-10-12 11:24             ` Andreas Schwab
2006-10-12 11:37               ` David Kastrup
2006-10-12 11:45                 ` Andreas Schwab
2006-10-12 14:47         ` Stefan Monnier [this message]
2006-10-12 14:53           ` David Kastrup
2006-10-12 15:24             ` Stefan Monnier
2006-10-12 18:11               ` Stuart D. Herring
2006-10-12 19:48                 ` Stefan Monnier
2006-10-12 20:27                   ` Stuart D. Herring
2006-10-13 11:19                     ` Richard Stallman
2006-10-12 22:38         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpscxbnpt.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=lennart.borgman.073@student.lu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).